[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Failure in building Emacs 23.0.50 on Cygwin (fwd)
From: |
d.henman |
Subject: |
Re: Failure in building Emacs 23.0.50 on Cygwin (fwd) |
Date: |
Sat, 08 Sep 2007 16:21:21 +0900 |
Having said that, the original supplied patch was more symmetrical, in the
context it was given and easier to maintain and provided for a closure
reference.
So now we have #elif mixed with #else #ifdefs with #endif for the legacy
items....
You might has well have made the whole code segment modern using #elifs...
Are there any conventions regarding this?
Regards,
darel henman
d.henman <address@hidden> wrote:
>
> Thanks from all of us unfortunate ones who have to use cygwin.
>
> In case you can't find the patch I will inline it below. My papers are in,
> so there is no legal problem.
>
> Regards,
> Darel Henman
>
> Dan Nicolaescu <address@hidden> wrote:
>
> > Angelo Graziosi <address@hidden> writes:
> >
> > > On Wed, 5 Sep 2007, Dan Nicolaescu wrote:
> > >
> > > > Angelo Graziosi <address@hidden> writes:
> > > >
> > > > > As I said in the last replay, I can suspend/resume both (emacs,
> > > > > emacsclient).
> > > > >
> > > > > After resume, I can continue to edit files typing in the terminal.
> > > > >
> > > > > All these things with a build of Emacs checked out about 12 hours
> > ago,
> > > > > having applied the 'famous' patch...
> > > >
> > > > Thanks! Then, IMO, the patch should go in.
> > > >
> > > >
> > >
> > > Who should submit it ? If you can and if the patch is valid, may you ?
> >
> > I will do it later today in case nobody beat me to it.
> --- term.c 2007-08-30 06:46:50.000000000 +0900
> +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900
> @@ -3131,6 +3131,10 @@
> setpgrp ();
> no_controlling_tty = 1;
> #else
> +#ifdef CYGWIN
> + setsid ();
> + no_controlling_tty = 1;
> +#else
> #ifdef TIOCNOTTY /* Try BSD ioctls. */
> sigblock (sigmask (SIGTTOU));
> fd = emacs_open ("/dev/tty", O_RDWR, 0);
> @@ -3145,6 +3149,7 @@
> /* Unknown system. */
> croak ();
> #endif /* ! TIOCNOTTY */
> +#endif /* ! CYGWIN */
> #endif /* ! USG */
> }
> #endif
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), (continued)
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), d.henman, 2007/09/06
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Jashy, 2007/09/07
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), d.henman, 2007/09/08
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Richard Stallman, 2007/09/08
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), David Kastrup, 2007/09/09
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Richard Stallman, 2007/09/09
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Angelo Graziosi, 2007/09/09
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Richard Stallman, 2007/09/10
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), d.henman, 2007/09/09
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Richard Stallman, 2007/09/09
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd),
d.henman <=
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Dan Nicolaescu, 2007/09/07
- NEW failure in building Emacs 23.0.50 on Cygwin, Angelo Graziosi, 2007/09/07
- Re: NEW failure in building Emacs 23.0.50 on Cygwin, Stefan Monnier, 2007/09/07
- Re: NEW failure in building Emacs 23.0.50 on Cygwin, Angelo Graziosi, 2007/09/07
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Andreas Schwab, 2007/09/05
- Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), d.henman, 2007/09/05
Re: Failure in building Emacs 23.0.50 on Cygwin (fwd), Angelo Graziosi, 2007/09/05