[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Incorrect interactive spec in customize-group
From: |
T. V. Raman |
Subject: |
Re: Incorrect interactive spec in customize-group |
Date: |
Mon, 30 Jul 2007 06:31:09 -0700 |
fixed now -- thanks!
>>>>> "Stefan" == Stefan Monnier <address@hidden> writes:
>> Command customize-group appears to have an incorrect
>> interactive spec --- and consequently fails to prompt for
>> the group to customize when called interactively.
Stefan>
Stefan> Does the patch below fix it?
Stefan>
Stefan>
Stefan> Stefan
Stefan>
Stefan>
Stefan> --- cus-edit.el 26 jui 2007 14:47:51 -0400 1.323 +++
Stefan> cus-edit.el 27 jui 2007 14:32:06 -0400 @@ -141,9
Stefan> +141,9 @@
Stefan>
Stefan> (require 'cus-face) (require 'wid-edit)
Stefan> -(eval-when-compile - (defvar
Stefan> custom-versions-load-alist) ; from cus-load - (defvar
Stefan> recentf-exclude)) ; from recentf.el + +(defvar
Stefan> custom-versions-load-alist) ; from cus-load +(defvar
Stefan> recentf-exclude) ; from recentf.el
Stefan>
Stefan> (condition-case nil (require 'cus-load) @@ -1032,22
Stefan> +1032,20 @@ t nil nil (if group (symbol-name
Stefan> major-mode)))))))) (customize-group
Stefan> (custom-group-of-mode mode)))
Stefan>
Stefan> - -;;;###autoload -(defun customize-group (&optional
Stefan> group prompt-for-group other-window) - "Customize
Stefan> GROUP, which must be a customization group." -
Stefan> (interactive) - (and (null group) - (or
Stefan> prompt-for-group (called-interactively-p)) +(defun
Stefan> customize-read-group () (let ((completion-ignore-case
Stefan> t)) - (setq group (completing-read "Customize group
Stefan> (default emacs): " obarray (lambda (symbol) (or (and
Stefan> (get symbol 'custom-loads) (not (get symbol
Stefan> 'custom-autoload))) (get symbol 'custom-group))) -
Stefan> t)))) + t))) + +;;;###autoload +(defun
Stefan> customize-group (&optional group) + "Customize GROUP,
Stefan> which must be a customization group." + (interactive
Stefan> (list (customize-read-group))) (when (stringp group)
Stefan> (if (string-equal "" group) (setq group 'emacs) @@
Stefan> -1055,15 +1053,8 @@ (let ((name (format "*Customize
Stefan> Group: %s*" (custom-unlispify-tag-name group)))) (if
Stefan> (get-buffer name) - (if other-window - (let
Stefan> ((pop-up-windows t) - (same-window-buffer-names nil)
Stefan> - (same-window-regexps nil)) - (pop-to-buffer name))
Stefan> - (pop-to-buffer name)) - (funcall (if other-window -
Stefan> 'custom-buffer-create-other-window -
Stefan> 'custom-buffer-create) + (pop-to-buffer name) +
Stefan> (custom-buffer-create (list (list group
Stefan> 'custom-group)) name (concat " for group " @@ -1072,8
Stefan> +1063,11 @@ ;;;###autoload (defun
Stefan> customize-group-other-window (&optional group)
Stefan> "Customize GROUP, which must be a customization
Stefan> group, in another window." - (interactive) -
Stefan> (customize-group group t t)) + (interactive (list
Stefan> (customize-read-group))) + (let ((pop-up-windows t) +
Stefan> (same-window-buffer-names nil) + (same-window-regexps
Stefan> nil)) + (customize-group group)))
Stefan>
Stefan> ;;;###autoload (defalias 'customize-variable
Stefan> 'customize-option) @@ -1254,30 +1248,22 @@ (< minor1
Stefan> minor2)))))
Stefan>
Stefan> ;;;###autoload -(defun customize-face (&optional
Stefan> face prompt-for-face other-window) +(defun
Stefan> customize-face (&optional face) "Customize FACE,
Stefan> which should be a face name or nil. If FACE is nil,
Stefan> customize all faces. If FACE is actually a
Stefan> face-alias, customize the face it is aliased to.
Stefan>
Stefan> Interactively, when point is on text which has a
Stefan> face specified, suggest to customize that face, if
Stefan> it's customizable." - (interactive) - (and (null
Stefan> face) - (or prompt-for-face (called-interactively-p))
Stefan> - (setq face (read-face-name "Customize face" "all
Stefan> faces" t))) + (interactive (list (read-face-name
Stefan> "Customize face" "all faces" t))) (if (member face
Stefan> '(nil "")) (setq face (face-list))) (if (and (listp
Stefan> face) (null (cdr face))) (setq face (car face))) -
Stefan> (let ((create-buffer-fn (if other-window -
Stefan> 'custom-buffer-create-other-window -
Stefan> 'custom-buffer-create))) (if (listp face) - (funcall
Stefan> create-buffer-fn + (custom-buffer-create
Stefan> (custom-sort-items - (mapcar (lambda (s) - (list s
Stefan> 'custom-face)) - face) + (mapcar (lambda (s) (list s
Stefan> 'custom-face)) face) t nil) "*Customize Faces*") ;;
Stefan> If FACE is actually an alias, customize the face it
Stefan> is aliased to. @@ -1285,10 +1271,10 @@ (setq face
Stefan> (get face 'face-alias))) (unless (facep face) (error
Stefan> "Invalid face %S" face)) - (funcall create-buffer-fn
Stefan> + (custom-buffer-create (list (list face
Stefan> 'custom-face)) (format "*Customize Face: %s*" -
Stefan> (custom-unlispify-tag-name face)))))) +
Stefan> (custom-unlispify-tag-name face)))))
Stefan>
Stefan> ;;;###autoload (defun customize-face-other-window
Stefan> (&optional face) @@ -1297,8 +1283,11 @@
Stefan>
Stefan> Interactively, when point is on text which has a
Stefan> face specified, suggest to customize that face, if
Stefan> it's customizable." - (interactive) -
Stefan> (customize-face face t t)) + (interactive (list
Stefan> (read-face-name "Customize face" "all faces" t))) +
Stefan> (let ((pop-up-windows t) + (same-window-buffer-names
Stefan> nil) + (same-window-regexps nil)) + (customize-face
Stefan> face)))
Stefan>
Stefan> (defalias 'customize-customized 'customize-unsaved)
Stefan>
--
Best Regards,
--raman
Email: address@hidden
WWW: http://emacspeak.sf.net/raman/
AIM: emacspeak GTalk: address@hidden
PGP: http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman
IRC: irc://irc.freenode.net/#emacs