[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: vc-revert broken for Subversion files
From: |
Richard Stallman |
Subject: |
Re: vc-revert broken for Subversion files |
Date: |
Tue, 24 Jul 2007 12:45:39 -0400 |
* vc-hooks.el: Generalize stay-local-p to operate on lists of
files. Change two keybindings to point to new function names.
* vc-arch.el, vc-bzr.el, vc-cvs.el, vc-hg.el, vc-mcvs.el, vc-rcs.el,
vc-sccs.el, vc-svn.el: These now implement the NewVC-fileset.
* vc.el: Adapted for NewVC-fileset, but no functional changes yet.
yes.
unfortunately, even w/ this ChangeLog entry, i am unable to determine the
intent (sense) of the "generalization". my doubt is as follows:
I have asked him to put in a clear and detailed change log entry.
when applied to many files, i can imagine two equally valid policies:
(a) if any file of the list is stay-local-p, enable optimizations.
(b) if all files of the list are stay-local-p, enable optimizations.
as is (just checked in), the code supports (a) but not (b). could
maintainers of client code give this some thought, and confirm or revise
the code accordingly? it comes down to "any" vs "all" semantics, of
which i'm slightly paranoid, having been bitten in a previous life...
the more i think about it, the more (b) would make sense (AND gate),
since optimizations may not be possible if any one file in the list is
NOT stay-local-p. this boolean stuff is (simply ;-) weird...
Could you write to him and Stefan to discuss the question?