|
From: | Jan Djärv |
Subject: | Re: XEmbed patches |
Date: | Fri, 20 Jul 2007 08:50:39 +0200 |
User-agent: | Thunderbird 2.0.0.4 (Macintosh/20070604) |
Timo Savola skrev:
Here is the XEmbed protocol support I wrote last year [1]. RMS asked me to bring it up again after the release of Emacs 22 [2]. [1] http://lists.gnu.org/archive/html/emacs-devel/2006-02/msg00017.html [2] http://lists.gnu.org/archive/html/emacs-devel/2006-02/msg00162.html There are five incremental patches plus one additional one (gtk-scrollbar-position) which I like for aesthetic reasons. The code hasn't been changed since the last submission (if I remember correctly), but I've regenerated the patches against 22.1. The patches can also be viewed in a Git repository at http://timo.stc.cx/git/?p=emacs-xembed.git .
It looks OK to me. It is good that you use gtk_plug for the Gtk+ case. I'm sure that some issues will come up when this code gets tested, but the general approach looks good.
One thing that would be cool to have is to be able to embed a frame from emacsclient. You can do that now with frame parameters and eval, but I was thinking for something like a defun create-embedded-frame or something like that. Just to simplify things.
Jan D.
[Prev in Thread] | Current Thread | [Next in Thread] |