emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes to hi-lock before release.


From: Richard Stallman
Subject: Re: Changes to hi-lock before release.
Date: Sat, 21 Apr 2007 10:30:13 -0400

I just clarified the documentation of this feature, as well
as fixing Texinfo usage.  But I think some change is probably
called for in the feature.

    +(defvar hi-lock-file-patterns-policy 'never

Shouldn't that be a defcustom?
It should also have a risky-local-variable property
since its value can be a function.

Also, it seems absurd for an explicit call to hi-lock-find-patterns to
check this variable.  If the user explicitly gives the command, it
should be obeyed.  I think that hi-lock-file-patterns-policy should be
tested only when hi-lock-find-patterns is called in other ways (such
as by find-file).

I have not changed the code.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]