emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The *Warnings* buffer and undo


From: David Kastrup
Subject: Re: The *Warnings* buffer and undo
Date: Wed, 28 Mar 2007 21:36:52 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux)

Glenn Morris <address@hidden> writes:

> Richard Stallman wrote:
>
>>     Does the *Warnings* buffer really need to save undo info? Why not set 
>>     buffer-undo-list to t in this buffer?
>>
>> I agree completely.  Would someone please do that?
>
> Do you mean this:
>
>
> *** warnings.el 21 Jan 2007 02:44:23 -0000 1.11
> --- warnings.el 28 Mar 2007 00:47:05 -0000
> ***************
> *** 237,242 ****
> --- 237,243 ----
>          (level-info (assq level warning-levels))
>               start end)
>               (with-current-buffer buffer
> +           (let ((buffer-undo-list t))

I don't think it is a good idea to let-bind buffer-undo-list here:
instead it should generally be set to t in the buffer.

Otherwise undo information will be recorded sparsely (for example, for
user input), leading to inconsistent results.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum




reply via email to

[Prev in Thread] Current Thread [Next in Thread]