Re: next-error-highlight = t - highlighting doesn't stay until you moveto the next locus

[Eli Zaretskii]

> From: "Drew Adams" <address@hidden>
> Cc: <address@hidden>
> Date: Sat, 24 Mar 2007 09:50:25 -0700
> 
> > > The doc string says:
> > >
> > > "If t, highlight the locus indefinitely until some
> > >  other locus replaces it."
> > >
> > > I wish it were so. However, the code says this:
> > >
> > > (if (or (eq next-error-highlight t)
> > >         (numberp next-error-highlight))
> > >     ;; We want highlighting:
> > >     ;; delete overlay on next input.  <---------- NOT GOOD
> > >     (add-hook 'pre-command-hook 'compilation-goto-locus-delete-o)
> > > ...
> >
> > I cannot find this code in the current CVS version of simple.el
> > (assuming that this where you take it from).  Please see if the latest
> > code still has the problem.
> 
> Yes, the latest code in CVS still has the problem. See the definition of
> `compilation-goto-locus' in compile.el. Thanks for looking into this.

If I understand correctly, the problem is that `next-error-highlight's
documentation on simple.el is inconsistent with what
`compilation-goto-locus' (from compile.el) actually does.  I don't
know how to fix that, since next-error-highlight' is a general-purpose
variable, whose use is not limited to compile.el.  This is certainly
not a simple doc string problem, so perhaps we should leave this until
after the release.