Re: Fwd: pcomplete bug with special display buffers

[David Hansen]

On Tue, 06 Mar 2007 04:05:24 +0100 David Hansen wrote:

> On Mon, 05 Mar 2007 12:33:13 -0500 Chong Yidong wrote:
>
>> David Hansen <address@hidden> writes:
>>
>>> Hello,
>>>
>>> is there anything wrong with this one character patch or did it just
>>> got lost?
>>>
>>> I'm using it now for about two weeks and it seems to work pretty
>>> well.
>>
>> Looks good; I checked it in.  Thanks.
>
> Thanks.  In the meantime I noticed that the (more or less same) bug
> is spread all over the GNU Emacs sources (well, I might exaggerate a
> bit).  The attached patch is for lisp.el, the same happens at least
> in comint.el, I haven't investigated the other results that a grep
> showed me.
>
> The bug in lisp and comint completion won't throw an error as in
> pcomplete.el.  To reproduce it you have resize the special frame so
> that not all possible completions fit within the window. Repeated TAB
> key strokes won't scroll the buffer.
>

Attached the patch for comint.el.  Could someone please have a look
at `switch-to-completions' in simple.el?  My window manager doesn't
allow emacs to focus other frames so it won't work for me anyways.

Grep indicates that the same bug might be present in org.el,
python.el and idlwave.el.  I don't use these modes, would be glad if
someone else can check these.

David

Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.358
diff -u -r1.358 comint.el
--- lisp/comint.el      23 Feb 2007 19:21:25 -0000      1.358
+++ lisp/comint.el      7 Mar 2007 14:58:11 -0000
@@ -2943,7 +2943,7 @@
 (defun comint-dynamic-list-completions (completions)
   "List in help buffer sorted COMPLETIONS.
 Typing SPC flushes the help buffer."
-  (let ((window (get-buffer-window "*Completions*")))
+  (let ((window (get-buffer-window "*Completions*" t)))
     (setq completions (sort completions 'string-lessp))
     (if (and (eq last-command this-command)
             window (window-live-p window) (window-buffer window)