[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Pathnames with two (or more) slashes in Makefile.c
From: |
Sascha Wilde |
Subject: |
Re: Pathnames with two (or more) slashes in Makefile.c |
Date: |
Mon, 29 Jan 2007 21:21:12 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) |
Jan Djärv <address@hidden> wrote:
> Sascha Wilde skrev:
>> Jan Djärv <address@hidden> wrote:
[...]
>> So the problem is, that the double slash is written unquoted to
>> Makefile.c where it gets interpreted as a comment.
>>
>> This is IMO a bug.
>>
>> When generating Makefile.c consecutive slashes hould either be reduced
>> to one or appropriately quoted.
>
> Actually it was a bug in my patch, I should not use #define if a
> double slash may be present. I briefly checked the other #define:s in
> Makefile.in and mostly the valuse comes from s/*.h or m/*.h, so we
> have control over these.
>
> I've checked in a fix, please try it.
Sorry, maybe I'm seriously missing something here, but I can't see
such a change by you, neither in CVS nor in the ChangeLog.
And, build still fails... :-(
FWIW: my workaround for now looks like this:
--- a/configure.in
+++ b/configure.in
@@ -3256,6 +3256,7 @@
< Makefile.c > junk1.c
sed -e '1,/start of cpp stuff/d'\
-e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+ -e 's,\(#.*\)//\+,\1/,g' \
< Makefile.c > junk.c
$CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
sed -e 's/^ / /' -e '/^#/d' -e '/^[ ]*$/d' > junk2.c
@@ -3272,6 +3273,7 @@
< Makefile.c > junk1.c
sed -e '1,/start of cpp stuff/d'\
-e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+ -e 's,\(#.*\)//\+,\1/,g' \
< Makefile.c > junk.c
$CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
sed -e 's/^ / /' -e '/^#/d' -e '/^[ ]*$/d' > junk2.c
cheers
sascha
--
Sascha Wilde -.-. ..- .-. .. --- ... .. - -.--
-.- .. .-.. .-.. . -..
- .... .
-.-. .- -
- Latest configure.in change breaks building, Sascha Wilde, 2007/01/27
- Re: Latest configure.in change breaks building, Jan Djärv, 2007/01/28
- Pathnames with two (or more) slashes in Makefile.c (was: Latest configure.in change breaks building), Sascha Wilde, 2007/01/28
- Re: Pathnames with two (or more) slashes in Makefile.c, Jan Djärv, 2007/01/29
- Re: Pathnames with two (or more) slashes in Makefile.c,
Sascha Wilde <=
- Re: Pathnames with two (or more) slashes in Makefile.c, Jan Djärv, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/31
- Re: Pathnames with two (or more) slashes in Makefile.c, Jan Djärv, 2007/01/31
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/31
- Re: Pathnames with two (or more) slashes in Makefile.c, Jan Djärv, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Jan Djärv, 2007/01/30
- Re: Pathnames with two (or more) slashes in Makefile.c, Sascha Wilde, 2007/01/30