[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: compilation-previous-error fails if first error is a
From: |
Nick Roberts |
Subject: |
Re: address@hidden: compilation-previous-error fails if first error is at start of buffer] |
Date: |
Thu, 11 Jan 2007 17:05:41 +1300 |
>...
> (You may have to edit this a bit because of line breaks in this mail
> message.) Now do
>
> M-x compilation-mode
>
> Go to the beginning of the buffer. Press TAB. The point should move to
> the second error line. Press TAB again -> to third line.
>
> Now press S-TAB. Should go to second line. S-TAB again should go to
> first line, but it does not.
>
> Is this enough to reproduce it for you?
Does this fix it? You'll need to gorilla test it to check there are no new
bugs.
--
Nick http://www.inet.net.nz/~nickrob
*** compile.el 09 Jan 2007 17:31:50 +1300 1.414
--- compile.el 11 Jan 2007 17:03:44 +1300
*************** Just inserts the text, but uses `insert-
*** 1500,1508 ****
(error ,error compilation-error))
;; prop 'message usually has 2 changes, on and off, so re-search if off
(or (setq msg (get-text-property pt 'message))
! (if (setq pt (,property-change pt 'message))
! (setq msg (get-text-property pt 'message)))
! (error ,error compilation-error))
(or (< (cadr msg) compilation-skip-threshold)
(if different-file
(eq (prog1 last (setq last (nth 2 (car msg))))
--- 1500,1510 ----
(error ,error compilation-error))
;; prop 'message usually has 2 changes, on and off, so re-search if off
(or (setq msg (get-text-property pt 'message))
! (progn
! (setq pt (or (,property-change pt 'message)
! (if (> n 0) (point-max) (point-min))))
! (unless (setq msg (get-text-property pt 'message))
! (error ,error compilation-error))))
(or (< (cadr msg) compilation-skip-threshold)
(if different-file
(eq (prog1 last (setq last (nth 2 (car msg))))
*************** Does NOT find the source line like \\[ne
*** 1543,1551 ****
(if (get-buffer-process (current-buffer))
"No more %ss yet"
"Moved past last %s"))
- ;; Don't move "back" to message at or before point.
- ;; Pass an explicit (point-min) to make sure pt is non-nil.
- (setq pt (previous-single-property-change pt 'message nil (point-min)))
(compilation-loop < previous-single-property-change 1+
"Moved back before first %s")))
(goto-char pt)
--- 1545,1550 ----
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], (continued)
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Nick Roberts, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Jan Djärv, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Lennart Borgman (gmail), 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Jan Djärv, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Lennart Borgman (gmail), 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Stefan Monnier, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Jan Djärv, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Richard Stallman, 2007/01/08
- Bug reporting (was: address@hidden: compilation-previous-error fails if first error is at start of buffer]), Stefan Monnier, 2007/01/08
- Re: Bug reporting, Lennart Borgman (gmail), 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer],
Nick Roberts <=
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Nick Roberts, 2007/01/18
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Richard Stallman, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Nick Roberts, 2007/01/08
- Re: address@hidden: compilation-previous-error fails if first error is at start of buffer], Chris Moore, 2007/01/08