Re: Bug in incremental undrawing of mouseover highlighting

[Eli Zaretskii]

> Cc: address@hidden,  address@hidden
> From: Chong Yidong <address@hidden>
> Date: Wed, 22 Nov 2006 10:07:55 -0500
> 
> Eli Zaretskii <address@hidden> writes:
> 
> >> + #ifdef HAVE_WINDOW_SYSTEM
> >> +   if (dpyinfo && EQ (window, dpyinfo->mouse_face_window))
> >> +     clear_mouse_face (dpyinfo);
> >> + #endif
> >> + 
> >
> > Are these #ifdef's really right?  The mouse highlight is supported not
> > only in builds that define HAVE_WINDOW_SYSTEM.
> 
> note_mouse_highlight is only defined inside HAVE_WINDOW_SYSTEM.

That's true, but you weren't modifying note_mouse_highlight, you
referenced dpyinfo->mouse_face_window.  You will see that at least
src/msdos.c manipulates dpyinfo->mouse_face_window.  The MSDOS build
supports mouse highlight, but does not define HAVE_WINDOW_SYSTEM, and
set_window_buffer, where you suggested to make the change, is compiled
into the MSDOS port.