Problem report #46

[Dan Nicolaescu]

This looks like it might be a duplicate of #45

CID: 46
Checker: RESOURCE_LEAK (help)
File: emacs/lib-src/etags.c
Function: Erlang_functions
Description: Variable "last" not freed or pointed-to in function "strncpy"

5575    static void
5576    Erlang_functions (inf)
5577         FILE *inf;
5578    {
5579      char *cp, *last;
5580      int len;
5581      int allocated;
5582    
5583      allocated = 0;
5584      len = 0;
5585      last = NULL;
5586    

At conditional (1): "feof == 0" taking true path
At conditional (2): "((readline), (cp = (lb).buffer)), (1 != 0)" taking true 
path

5587      LOOP_ON_INPUT_LINES (inf, lb, cp)
5588        {

At conditional (3): "*(cp + 0) == 0" taking false path

5589          if (cp[0] == '\0')        /* Empty line */
5590            continue;

At conditional (4): "_wht[*(cp + 0) & 255] != 0" taking false path

5591          else if (iswhite (cp[0])) /* Not function nor attribute */
5592            continue;

At conditional (5): "*(cp + 0) == 37" taking false path

5593          else if (cp[0] == '%')    /* comment */
5594            continue;

At conditional (6): "*(cp + 0) == 34" taking false path

5595          else if (cp[0] == '"')    /* Sometimes, strings start in column 
one */
5596            continue;

At conditional (7): "*(cp + 0) == 45" taking true path

5597          else if (cp[0] == '-')    /* attribute, e.g. "-define" */
5598            {
5599              erlang_attribute (cp);

Event overwrite_var: Value "last" is overwritten in "last = 0"
Also see events: [alloc_fn][var_assign][pass_arg]

5600              last = NULL;
5601            }
5602          else if ((len = erlang_func (cp, last)) > 0)
5603            {
5604              /*
5605               * Function.  Store the function name so that we only
5606               * generates a tag for the first clause.
5607               */
5608              if (last == NULL)

Event alloc_fn: Called allocation function "xmalloc" [model]
Event var_assign: Assigned variable "last" to storage returned from "xmalloc"
Also see events: [var_assign][overwrite_var][pass_arg]

5609                last = xnew (len + 1, char);
5610              else if (len + 1 > allocated)
5611                xrnew (last, len + 1, char);
5612              allocated = len + 1;

Event pass_arg: Variable "last" not freed or pointed-to in function "strncpy"
Also see events: [alloc_fn][var_assign][overwrite_var]

5613              strncpy (last, cp, len);
5614              last[len] = '\0';
5615            }
5616        }
5617    }