[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: defface location in describe-face
From: |
drkm |
Subject: |
Re: defface location in describe-face |
Date: |
Tue, 04 Jan 2005 17:42:04 +0100 |
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (windows-nt) |
Stefan <address@hidden> writes:
>> replaced by (locally binding `find-variable-regexp'):
>> (let ((library (or file (symbol-file face 'defface)))
>> (find-variable-regexp find-face-regexp))
>> (find-function-search-for-symbol face 'variable library)))
> That's ugly.
Yes. That's why I pointed it out. And why I added
`find-face-noselect' in find-func.el. Initially, I did that trick
enclosing the calls to `find-variable-noselect' (ahem).
>> But I think `find-func' library should be fixed to handle arbitrary
>> kind of symbol (or at least other standard things than functions and
>> variables).
> Yes, that's what needs to be done.
> The rest of the patch looks OK, except that the "loaddefs.el" thingy should
> be removed (it's only done for variables, not for functions, and shouldn't
> be done for faces either).
Ok. I suppose I let you do it (just remove the `when' form).
--drkm