[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: All platforms fail with Unicode in menus.
From: |
Jan D. |
Subject: |
Re: All platforms fail with Unicode in menus. |
Date: |
Thu, 26 Aug 2004 20:30:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040810 |
David Kastrup wrote:
The best contender right now is GTK which gets it right, except that
it completely garbles the menus when garbage collection occurs during
their creation (the gc-cons-threshold setting at the end of this
example file more or less ensures that stuff gets garbled).
It seems that the string returned by ENCODE_UTF_8 gets collected during GC,
resulting in passing garbage to the GTK menu code.
I can work around the bug by this patch (the call to inhibit_garbage_collection
is present in macmenu.c), but I am not sure it is the correct way to fix this:
*** xmenu.c.~1.255.~ 2004-01-12 00:15:16.000000000 +0100
--- xmenu.c 2004-08-26 20:18:28.000000000 +0200
***************
*** 1930,1935 ****
--- 1930,1936 ----
FRAME_MENU_BAR_ITEMS (f) = menu_bar_items (FRAME_MENU_BAR_ITEMS (f));
items = FRAME_MENU_BAR_ITEMS (f);
+ inhibit_garbage_collection ();
/* Save the frame's previous menu bar contents data. */
if (previous_menu_items_used)
Can someone that knows ENCODE_UTF_8 and garbage collection well comment on this
patch?
Thanks,
Jan D.
Re: All platforms fail with Unicode in menus., YAMAMOTO Mitsuharu, 2004/08/30