Re: don't process $(LDFLAGS) with prefix-args

[Paul Jarc]

I wrote:
> The distributed Makefile.in's are similar enough, but somewhere in the
> 21.2 build process, Makefile.in is modified like so:

Sorry, my mistake.  That isn't happening; I had simply patched my 21.2
this way to make it compile.  So the bug hasn't reappeared - it was
never fixed. :/  ISTR what happened was that I posted this patch for
21.1 or 21.2, and it was agreed that it should be applied, but
apparently it never was.  It still works for me with 21.3.

The patch makes it so the user-supplied LDFLAGS is not processed by
YMF_PASS_LDFLAGS.  So on systems where $(LD) is $(CC), this patch
changes the interpretation of LDFLAGS in src/ to match its
interpretation in other subdirectories.  On systems where $(LD) is ld,
YMF_PASS_LDFLAGS is a no-op, so there is no real change: the
interpretation is still inconsistent among subdirectories.

--- Makefile.in.2       2003-03-27 14:42:33.000000000 -0500
+++ emacs-21.2/src/Makefile.in  2003-03-27 14:57:21.000000000 -0500
@@ -495,7 +495,7 @@
 #endif /* not ORDINARY_LINK */
 
 ALL_LDFLAGS = LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_TEMACS LD_SWITCH_MACHINE \
-        LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE $(LDFLAGS)
+        LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE
 
 /* A macro which other sections of Makefile can redefine to munge the
    flags before they're passed to LD.  This is helpful if you have
@@ -868,7 +868,7 @@
 #endif
 
 temacs: MAKE_PARALLEL $(LOCALCPP) $(STARTFILES) stamp-oldxmenu ${obj} 
${otherobj} OBJECTS_MACHINE prefix-args
-       $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) \
+       $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) $(LDFLAGS) \
     -o temacs ${STARTFILES} ${obj} ${otherobj}  \
     OBJECTS_MACHINE ${LIBES}
 


paul