bug#77816: closed ([PATCH] Fix deleting the first line of calc-trail-mode)

[GNU bug Tracking System]

Your message dated Tue, 15 Apr 2025 11:58:19 +0300
with message-id <86r01thkd0.fsf@gnu.org>
and subject line Re: bug#77816: [PATCH] Fix deleting the first line of 
calc-trail-mode
has caused the debbugs.gnu.org bug report #77816,
regarding [PATCH] Fix deleting the first line of calc-trail-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
77816: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77816
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix deleting the first line of calc-trail-mode Date: Mon, 14 Apr 2025 19:20:37 +0200

As of GNU Emacs 30.1 it's not possible to delete the first line of the
calc trail visible after invoking the Emacs calculator.

To reproduce:

1. Start Emacs calc: C-x * c
2. Enter a few numbers: 10 RET 20 RET 30 RET
3. Try deleting the trail lines, repeat for each line: t k

Expected behavior: all the trail lines are being deleted.

Actual behavior: the first line is still left, no error is reported.

This bug was introduced in commit
8e1376a39125c3ffc0484077b502444d853eca79, included since Emacs 28.1.
Before that commit, calc trail used its first line as a header, which
wasn't meant to be deleted.  After migrating to using header-line, the
code preserving the first line was kept intact, still preventing the
removal of the first line even though it's no longer special.

I'm attaching a patch fixing this behavior.

Best regards
-- 
Wojciech Siewierski

0001-Fix-deleting-the-first-line-of-calc-trail-mode.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#77816: [PATCH] Fix deleting the first line of calc-trail-mode
>
>
>
>
> Date: 
>
> Tue, 15 Apr 2025 11:58:19 +0300
>
>
>
>
> > From: Wojciech Siewierski <wojciech@siewierski.eu>
> > Date: Mon, 14 Apr 2025 19:20:37 +0200
> > 
> > As of GNU Emacs 30.1 it's not possible to delete the first line of the
> > calc trail visible after invoking the Emacs calculator.
> > 
> > To reproduce:
> > 
> > 1. Start Emacs calc: C-x * c
> > 2. Enter a few numbers: 10 RET 20 RET 30 RET
> > 3. Try deleting the trail lines, repeat for each line: t k
> > 
> > Expected behavior: all the trail lines are being deleted.
> > 
> > Actual behavior: the first line is still left, no error is reported.
> > 
> > This bug was introduced in commit
> > 8e1376a39125c3ffc0484077b502444d853eca79, included since Emacs 28.1.
> > Before that commit, calc trail used its first line as a header, which
> > wasn't meant to be deleted.  After migrating to using header-line, the
> > code preserving the first line was kept intact, still preventing the
> > removal of the first line even though it's no longer special.
> > 
> > I'm attaching a patch fixing this behavior.
>
> Thanks, I've now installed this on the emacs-30 release branch, and
> I'm closing this bug.
>
>
> --- End Message ---