bug#53133: closed (28.0.90; tabulated-list-sort doesn't work as expected)

[GNU bug Tracking System]

Your message dated Tue, 5 Sep 2023 18:57:26 -0700
with message-id 
<CADwFkm=zePNWwtXDCjDWPX0kWJK+U+Oi_8-OT=NZZwpAzPmrNg@mail.gmail.com>
and subject line Re: bug#53133: 28.0.90; tabulated-list-sort doesn't work as 
expected
has caused the debbugs.gnu.org bug report #48639,
regarding 28.0.90; tabulated-list-sort doesn't work as expected
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48639: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48639
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 28.0.90; tabulated-list-sort doesn't work as expected
>
>
>
>
> Date: 
>
> Sun, 09 Jan 2022 11:03:27 +0900
>
>
>
>
> User-agent: 
>
> Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.0.90 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
>
>
>
>
> Hi,
>
> tabulated-list-sort sometimes doesn't work as expected due to the change between
> 28.0.90 and 28.0.50.
>
> Here is how to reproduce:
> 1. Open Emacs from terminal with `emacs --no-init-file'
> 2. Type M-x list-buffers
> 3. Type C-x o (go to Buffer Menu)
> 4. Type C-M-Right 5 times to move on to "Fundamental" in "Mode" column
> 5. Type S 2 times or more to toggle sorting order
> 6. You will be able to see that "Size" column is selected as the sorting column
>    unexpectedly
>
> Looks like below change from 28.0.50 is releated to this issue, because it
> disappears when I just rewind this change.
>
> --- tabulated-list.el.org       2022-01-06 22:32:13.936852142 +0900
> +++ tabulated-list.el   2022-01-07 15:15:42.000000000 +0900
> @@ -574,7 +581,8 @@
>        (when not-last-col
>          (when (> pad-right 0) (insert (make-string pad-right ?\s)))
>          (insert (propertize
> -                 (make-string (- width (min width label-width)) ?\s)
> +                 ;; We need at least one space to align correctly.
> +                 (make-string (- width (min 1 width label-width)) ?\s)
>                   'display `(space :align-to ,next-x))))
>        (put-text-property opoint (point) 'tabulated-list-column-name name)
>        next-x)))
>
> Hope this will be fixed appropriately in the coming major release.
>
> Regards,
> Shingo
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
>
>
>
>
> Date: 
>
> Tue, 5 Sep 2023 18:57:26 -0700
>
>
>
>
> > Indeed, that was the root cause of this.  This bug is now fixed on
> > master (commit 2767c89db7).
>
> This bug was accidentally left open, so I'm closing it now.
>
>
> --- End Message ---