bug#62181: closed (Gnulib package keeps references to clisp, Python, Perl, and Bash)

[GNU bug Tracking System]

Your message dated Fri, 17 Mar 2023 22:48:12 +0100
with message-id <87fsa3vylf.fsf@gnu.org>
and subject line Re: [PATCH v2 1/2] gnu: gnulib: Reset the shebangs.
has caused the debbugs.gnu.org bug report #62181,
regarding Gnulib package keeps references to clisp, Python, Perl, and Bash
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62181: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62181
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Gnulib package keeps references to clisp, Python, Perl, and Bash
>
>
>
>
> Date: 
>
> Tue, 14 Mar 2023 09:34:52 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> The Gnulib package, which is meant to be source, retains references to
> several packages:
>
> --8<---------------cut here---------------start------------->8---
> $ guix describe
> Generation 250  Mar 12 2023 23:58:03    (current)
>   guix 1ed227d
>     repository URL: https://git.savannah.gnu.org/git/guix.git
>     branch: master
>     commit: 1ed227d7952af48efe50a2f6c9537e17c356daa1
> $ guix gc --references $(guix build gnulib)
> /gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8
> /gnu/store/76p04alhjimlv4cgijl670byf2m50qh8-clisp-2.49-92
> /gnu/store/bvnzi0z7i9qk31a03y64rs8sxrckkinr-python-3.9.9
> /gnu/store/hy6abswwv4d89zp464fw52z65fkzr7h5-perl-5.34.0
> --8<---------------cut here---------------end--------------->8---
>
> We should probably fix that and add #:allowed-references '().
>
> WDYT, Vivien?
>
> Thanks,
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH v2 1/2] gnu: gnulib: Reset the shebangs.
>
>
>
>
> Date: 
>
> Fri, 17 Mar 2023 22:48:12 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Vivien Kraus <vivien@planete-kraus.eu> skribis:
>
> > * gnu/packages/build-tools.scm (gnulib) [phase reset-shebangs]: After
> > installation, rewrite the /gnu/store shebangs in the distributed build-aux
> > files.
> > [inputs, native-inputs]: Add bash-minimal.
> > [phase let-autogen-execute-gnulib-tool]: Specify a shell to execute
> > gnulib-tool from autogen.sh.
>
> Applied with tweaks to the commit log.
>
> > +              (substitute* (find-files
> > +                            (string-append #$output "/src/gnulib")
> > +                            (lambda (fname stat)
> > +                              (and (not (string-suffix? 
> > "/lib/javaversion.class" fname))
> > +                                   (not (string-suffix? ".mo" fname)))))
>
> This leaves the shebang on ‘bin/gnulib-tool’, such that ‘gnulib’ keeps a
> reference to ‘bash-minimal’ (and nothing else).
>
> It’s not even convenient though because…
>
> > * gnu/packages/tls.scm (guile-gnutls) [phase patch-more-shebangs]: Fix how
> > autogen.sh invokes gnulib-tool, and how configure.ac invokes git-version-gen,
> > so as not to rely on shebangs.
>
> [...]
>
> > +              (substitute* "autogen.sh"
> > +                (("\\$gnulib_tool \\$gnulib_tool_options")
> > +                 "sh $gnulib_tool $gnulib_tool_options"))
>
> … this is still needed: GNULIB/bin/gnulib-tool, which has a correct
> shebang, is *not* used, and instead GNULIB/src/gnulib/gnulib-tool is
> used.
>
> Should we remove GNULIB/bin/gnulib-tool?  Or should we remove the other
> one?
>
> Anyway, applied as well, thank you!
>
> Ludo’.
>
>
> --- End Message ---