bug#62043: closed ([PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu)

[GNU bug Tracking System]

Your message dated Fri, 10 Mar 2023 18:16:48 +0000
with message-id 
<CIFaQNXvofB0414IpjYw2OzIiYaRJO-gbhcnhSiKNUVPpTMCgS-PoVZeZSgLdQVwBOYK77RUbdgAvK9PLkhmvV_ypkvkWF63HuAdGT5nptg=@rjt.dev>
and subject line Re: bug#62043: [PATCH] Fix enums appearing as structs in 
c-ts-base-mode's imenu
has caused the debbugs.gnu.org bug report #62043,
regarding [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
62043: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62043
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Date: Wed, 08 Mar 2023 01:49:49 +0000

X-Debbugs-CC: casouri@gmail.com

With {c, c++}-ts-mode, enums appear as structs in imenu. The attached patch fixes this.

Example:

enum Thing { A, B, C };

Should appear as Enum Thing

0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu
>
>
>
>
> Date: 
>
> Fri, 10 Mar 2023 18:16:48 +0000
>
>
>
>
> On Friday, March 10th, 2023 at 00:59, Yuan Fu <casouri@gmail.com> wrote:
> > 
> > > On Mar 8, 2023, at 6:04 PM, Randy Taylor dev@rjt.dev wrote:
> > > 
> > > On Wednesday, March 8th, 2023 at 18:27, Yuan Fu casouri@gmail.com wrote:
> > > 
> > > > > On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote:
> > > > > 
> > > > > X-Debbugs-CC: casouri@gmail.com
> > > > > 
> > > > > With {c, c++}-ts-mode, enums appear as structs in imenu. The attached 
> > > > > patch fixes this.
> > > > > 
> > > > > Example:
> > > > > enum Thing { A, B, C };
> > > > > 
> > > > > Should appear as Enum Thing
> > > > > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch>
> > > > 
> > > > Thanks! I wonder what determines which categories to merge together and 
> > > > which to not? If we separate Enums, should we also separate Unions?
> > > > 
> > > > Yuan
> > > 
> > > I think they should all be separate actually. Attached a patch that does 
> > > so.<0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch>
> > 
> > 
> > That’s probably the right thing to do. I applied the patch, thanks!
> > 
> > Yuan
>
> Thanks, closing.
>
>
> --- End Message ---