bug#61489: closed ([PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵)

[GNU bug Tracking System]

Your message dated Sat, 04 Mar 2023 13:26:58 +0200
with message-id <83y1ocaha5.fsf@gnu.org>
and subject line Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 
32768
has caused the debbugs.gnu.org bug report #61489,
regarding [PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61489: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61489
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
>
>
>
>
> Date: 
>
> Mon, 13 Feb 2023 23:00:06 +0300
>
>
>
>
> Originally discovered by Tyler Dodge in his article "Significant Garbage
> Collection Improvement For Emacs".
>
> While testing this change on Archlinux system with Intel i5-7200U CPU,
> average time of garbage collection gets reduced by ≈25%. While
> monitoring PSS of emacs with and without customizations loaded before
> and after the patch, no statistically significant differences were
> discovered. So overall, this change is a win.
>
> * src/alloc.c (BLOCK_ALIGN): increase from 2¹⁰ to 2¹⁵
> ---
>  src/alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/alloc.c b/src/alloc.c
> index c25e81d1dde..d278b01343d 100644
> --- a/src/alloc.c
> +++ b/src/alloc.c
> @@ -1083,7 +1083,7 @@ lisp_free (void *block)
>     BLOCK_BYTES and guarantees they are aligned on a BLOCK_ALIGN boundary.  */
>  
>  /* Byte alignment of storage blocks.  */
> -#define BLOCK_ALIGN (1 << 10)
> +#define BLOCK_ALIGN (1 << 15)
>  verify (POWER_OF_2 (BLOCK_ALIGN));
>  
>  /* Use aligned_alloc if it or a simple substitute is available.
> -- 
> 2.39.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
>
>
>
>
> Date: 
>
> Sat, 04 Mar 2023 13:26:58 +0200
>
>
>
>
> > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Date: Thu, 16 Feb 2023 18:07:55 +0300
> > 
> > Originally discovered by Tyler Dodge in his article "Significant Garbage
> > Collection Improvement For Emacs".
> > 
> > While testing this change on Archlinux system with Intel i5-7200U CPU,
> > average time of garbage collection gets reduced by ≈25%. Other users
> > report improvements up to 50%. While monitoring PSS of emacs with and
> > without customizations loaded before and after the patch, no
> > statistically significant differences were discovered. So overall, this
> > change is a win.
> > 
> > * src/alloc.c (BLOCK_ALIGN): increase from 1024 to 32768
>
> Thanks, installed on the master branch, and closing the bug.
>
>
> --- End Message ---