bug#61560: closed ([Guix Data Service] Comparing package derivations: Fix inconsistent verbage.)

[GNU bug Tracking System]

Your message dated Fri, 17 Feb 2023 17:11:29 +0000
with message-id <878rgwkyhx.fsf@cbaines.net>
and subject line Re: [bug#61560] [Guix Data Service] Comparing package 
derivations: Fix inconsistent verbage.
has caused the debbugs.gnu.org bug report #61560,
regarding [Guix Data Service] Comparing package derivations: Fix inconsistent 
verbage.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61560: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61560
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [Guix Data Service] Comparing package derivations: Fix inconsistent verbage.
>
>
>
>
> Date: 
>
> Thu, 16 Feb 2023 17:26:45 -0500
>
>
>
>
> Harmonize "Build change" options between the selection menu and the 
> documentation
>
> I don't have a preference about which phrase is chosen. Please use your
> judgement in fixing this to ensure consistency throughout the user interface.
>
> * guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
> "Still broken" with "Still failing" in the "Build change" help text.
> ---
>  guix-data-service/web/compare/html.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix-data-service/web/compare/html.scm 
> b/guix-data-service/web/compare/html.scm
> index 58fb514..44acb81 100644
> --- a/guix-data-service/web/compare/html.scm
> +++ b/guix-data-service/web/compare/html.scm
> @@ -797,7 +797,7 @@ derivation")
>                             (dd
>                              "At least one successful build for both the base
>  and target derivations")
> -                           (dt "Still broken")
> +                           (dt "Still failing")
>                             (dd
>                              "No successful builds and at least one failed 
> builds for both the base and target derivations")
>                             (dt "Unknown")
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#61560] [Guix Data Service] Comparing package derivations: Fix inconsistent verbage. Date: Fri, 17 Feb 2023 17:11:29 +0000 User-agent: mu4e 1.8.11; emacs 28.2

Leo Famulari <leo@famulari.name> writes:

> Harmonize "Build change" options between the selection menu and the 
> documentation
>
> I don't have a preference about which phrase is chosen. Please use your
> judgement in fixing this to ensure consistency throughout the user interface.
>
> * guix-data-service/web/compare/html.scm (compare/package-derivations): 
> Replace
> "Still broken" with "Still failing" in the "Build change" help text.
> ---
>  guix-data-service/web/compare/html.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix-data-service/web/compare/html.scm 
> b/guix-data-service/web/compare/html.scm
> index 58fb514..44acb81 100644
> --- a/guix-data-service/web/compare/html.scm
> +++ b/guix-data-service/web/compare/html.scm
> @@ -797,7 +797,7 @@ derivation")
>                             (dd
>                              "At least one successful build for both the base
>  and target derivations")
> -                           (dt "Still broken")
> +                           (dt "Still failing")
>                             (dd
>                              "No successful builds and at least one failed 
> builds for both the base and target derivations")
>                             (dt "Unknown")

Looks good to me, I've pushed this now.

Thanks,

Chris

signature.asc
Description: PGP signature

--- End Message ---