emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58873: closed (29.0.50; Fix indent-line-function in tree-sitter)


From: GNU bug Tracking System
Subject: bug#58873: closed (29.0.50; Fix indent-line-function in tree-sitter)
Date: Sat, 12 Nov 2022 20:34:03 +0000

Your message dated Sat, 12 Nov 2022 12:33:41 -0800
with message-id 
<CADwFkmmhY6Lz1VXTKNVhAEzX8KG8vNQ3pLRwn52zNH-VL3dyuQ@mail.gmail.com>
and subject line Re: bug#58873: 29.0.50; Fix indent-line-function in tree-sitter
has caused the debbugs.gnu.org bug report #58873,
regarding 29.0.50; Fix indent-line-function in tree-sitter
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58873: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58873
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 29.0.50; Fix indent-line-function in tree-sitter Date: Sat, 29 Oct 2022 21:11:27 +0200
Hi Yuan!

There were some regressions with the new indent-line-function - see
attached patch.  We need the point, not the indentation, and the
save-excursion is actually needed.

consider:

```
foo({
  thing: 1,
                tho|ng: 2, // <--- point is |
})
```

if you indent now you want to end up like this:

```
foo({
  thing: 1,
  tho|ng: 2, // <--- point is |
})
```

or if 

```
foo({
  thing: 1,
|thong: 2, // <--- point is |
})
```
You want to end up like this:

```
foo({
  thing: 1,
  |thong: 2, // <--- point is |
})
```

This patch addresses this :-)

In addition there was a bug where the parent-bol didn't indent
correctly, this should also be fixed now.

Thanks again, Yuan!

Theo

Attachment: 0001-Fix-indent-line-function.patch
Description: Fix indent-line-function in tree-sitter


--- End Message ---
--- Begin Message --- Subject: Re: bug#58873: 29.0.50; Fix indent-line-function in tree-sitter Date: Sat, 12 Nov 2022 12:33:41 -0800
Yuan Fu <casouri@gmail.com> writes:

> I applied your change (manually), thanks!

It seems this was installed but never closed so I'm doing that now.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]