emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58843: closed (Print "decrypted" rot13 text is buffer is read-only)


From: GNU bug Tracking System
Subject: bug#58843: closed (Print "decrypted" rot13 text is buffer is read-only)
Date: Fri, 04 Nov 2022 23:10:02 +0000

Your message dated Fri, 04 Nov 2022 23:09:08 +0000
with message-id <874jvejp0r.fsf@posteo.net>
and subject line Re: bug#58843: Print "decrypted" rot13 text is buffer is 
read-only
has caused the debbugs.gnu.org bug report #58843,
regarding Print "decrypted" rot13 text is buffer is read-only
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58843: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58843
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Print "decrypted" rot13 text is buffer is read-only Date: Fri, 28 Oct 2022 18:24:58 +0000
Tags: patch


When someone sends you rot13'ed text but the buffer is read-only, it
seems the next best thing one can do is to print the decrypted text.  I
don't think it makes sense in general for `translate-region' to do the
same, so I just modified the code in rot13.el.


In GNU Emacs 29.0.50 (build 23, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.17.6) of 2022-10-22 built on rhea
Repository revision: ab283bddb2505e767bdf08b063c648b87d71d33a
Repository branch: feature/package+vc
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-pgtk --with-imagemagick'

Attachment: rot13.el
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#58843: Print "decrypted" rot13 text is buffer is read-only Date: Fri, 04 Nov 2022 23:09:08 +0000
Philip Kaludercic <philipk@posteo.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Philip Kaludercic <philipk@posteo.net>
>>> Cc: 58843@debbugs.gnu.org
>>> Date: Sat, 29 Oct 2022 16:25:07 +0000
>>> 
>>> > No, this is described in the "Rmail Rot13" node.
>>> 
>>> Ah yes.  How does this look like:
>>
>> OK, with two nits:
>>
>>> +@findex rot13-region
>>> +  If you are only interested in a region, the command @kbd{M-x
>>> +rot13-region} might be preferable.  This will decrypt the active
>>> +region in place.  If the buffer is read-only, it will attempt to
>>           ^^^^^^^^
>> "in-place"
>>
>>> +display the plain text in the echo area.  If the text is too long, a
>>> +separate buffer will be used.
>>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> Passive voice alert!  Suggest to rephrase
>>
>>   If the text is too long for the echo area, the command will pop up a
>>   temporary buffer with the decrypted text.
>
> Done.
>
>> Btw, is it "decrypted" or "encrypted/decrypted"?
>
> I guess the latter makes more sense, though it is not that important.
> I've adapted the change anyway.
>
>> Thanks.

I have pushed the patch with these modifications, and am therefore
closing the report.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]