bug#58810: closed (29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results)

[GNU bug Tracking System]

Your message dated Thu, 3 Nov 2022 11:48:54 -0700
with message-id <b37ec97a-054f-28fa-5756-812e92eb27b0@gmail.com>
and subject line Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes 
produces wrong results
has caused the debbugs.gnu.org bug report #58810,
regarding 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58810
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results Date: Wed, 26 Oct 2022 18:22:13 -0700

Starting from "emacs -Q -f -eshell":

  ~ $ echo $(list 'quote 'hello)
  'hell

The last character of "hello" was stripped. That's because 'eshell-stringify' tries to remove the trailing newline from 'pp-to-string', but it does so by always stripping the last character from the result. Obviously, that only works when the last character really is a newline.

Attached is a patch with regression tests for 'eshell-stringify' so that this works correctly.

0001-Only-strip-newlines-when-stringifying-a-value-for-Es.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results
>
>
>
>
> Date: 
>
> Thu, 3 Nov 2022 11:48:54 -0700
>
>
>
>
> On 10/26/2022 6:22 PM, Jim Porter wrote:
> > Attached is a patch with regression tests for 'eshell-stringify' so that 
> > this works correctly.
>
> Merged as d2a9dae40057ff16683d9c5f30a3b04500ebc4cf. Closing this bug.
>
>
> --- End Message ---