bug#58488: closed ([PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.)

[GNU bug Tracking System]

Your message dated Thu, 03 Nov 2022 17:46:16 +0100
with message-id <87bkpom1ed.fsf@cbaines.net>
and subject line Re: bug#58488: [PATCH] gnu: gnome: Include aarch64 in 
librsvg-for-system.
has caused the debbugs.gnu.org bug report #58488,
regarding [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58488: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58488
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system.
>
>
>
>
> Date: 
>
> Thu, 13 Oct 2022 11:20:48 +0100
>
>
>
>
> Since the staging merge, librsvg has been buildable for aarch64.
>
> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
> ---
>  gnu/packages/gnome.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 09a991b14c..ff9d95c244 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
>                               (system (or (%current-target-system)
>                                           (%current-system))))
>    ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly supported
> -  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
> -  (if (string-prefix? "x86_64-" system)
> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
> +  ;; platforms (FIXME).
> +  (if (or (string-prefix? "x86_64-" system)
> +          (string-prefix? "aarch64-" system))
>        librsvg
>        librsvg-2.40))
>  
> -- 
> 2.37.3
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#58488: [PATCH] gnu: gnome: Include aarch64 in librsvg-for-system. Date: Thu, 03 Nov 2022 17:46:16 +0100 User-agent: mu4e 1.8.9; emacs 28.1

Ludovic Courtès <ludo@gnu.org> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> Since the staging merge, librsvg has been buildable for aarch64.
>>
>> * gnu/packages/gnome.scm (librsvg-for-system): Use librsvg for aarch64.
>> ---
>>  gnu/packages/gnome.scm | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 09a991b14c..ff9d95c244 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -3753,8 +3753,10 @@ (define* (librsvg-for-system #:optional
>>                               (system (or (%current-target-system)
>>                                           (%current-system))))
>>    ;; Since librsvg 2.50 depends on Rust, and Rust is only correctly 
>> supported
>> -  ;; on x86_64 so far, use the ancient C version on other platforms (FIXME).
>> -  (if (string-prefix? "x86_64-" system)
>> +  ;; on x86_64 and aarch64 so far, use the ancient C version on other
>> +  ;; platforms (FIXME).
>> +  (if (or (string-prefix? "x86_64-" system)
>> +          (string-prefix? "aarch64-" system))
>
> With <https://issues.guix.gnu.org/58661> now fixed, I think you can go
> ahead and push this one, no?

Indeed, thanks for the reminder, I've pushed to master as
754f260753fb6ebe28325616bc08336a184e4621.

Chris

signature.asc
Description: PGP signature

--- End Message ---