bug#58386: closed (Age encryption : passage)

[GNU bug Tracking System]

Your message dated Wed, 19 Oct 2022 19:17:33 +0200
with message-id <87h6zzbo14.fsf@nckx>
and subject line Re: [PATCH v2] gnu: Add passage.
has caused the debbugs.gnu.org bug report #58386,
regarding Age encryption : passage
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58386: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58386
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Age encryption : passage
>
>
>
>
> Date: 
>
> Sun, 09 Oct 2022 00:42:15 +0200
>
>
>
>
> Hi!
>
> Small patch series following https://issues.guix.gnu.org/58340 for
> adding the fork of the password-store.
>
> I've made the choice to rename the existing passage game to
> passage-game in a first commit, I hope it's OK. 
>
> -- 
> Best regards,
> Nicolas Graves
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH v2] gnu: Add passage. Date: Wed, 19 Oct 2022 19:17:33 +0200

Hi Nicolas,

Nicolas Graves 写道：

Just as a reminder, this patch cannot be merged before 58340.

Thanks, I realised that after I sent it. I'll treat (and close) them as one bug for this reply.

I've pushed all 3 patches as ac553ba68e535810085dd838e48e4fa6ac553e67 et al with the following mods:

* gnu/packages/password-utils.scm (passage): New variable.

I fixed up the commit message to match the name, and addressed the following ‘guix lint’ warnings:

pass-age@1.7.4a0: no article allowed at the beginning of the synopsis age@1.0.0: sentences in description should be followed by two spaces

Whilst there, I turned @code{age-encryption.org/v1} into a full @url{}, and fixed up upstream's ‘config’ & ‘UNIX’ slang.

* gnu/packages/golang.scm
  (age): New variable.
  (go-filippo-io-cmd-age): New variable.
  (go-filippo-io-cmd-age-keygen): New variable.

 ^^
Our changelogs are never indented, you'd write:

* gnu/packages/golang.scm (age, go-filippo-io-cmd-age)
(go-filippo-io-cmd-age-keygen): New variables.

…but in this case, I was bold and removed the two go-filippo-io-cmd-age* packages completely. I moved ‘age’ to (gnu packages password-utils).

The partial recursion in the go-* variants made me nervous (and would probably prevent the move, although I didn't try).

If these variants are needed for something, it's not pass-age, and we can review them separately if/when needed. Is that acceptable?

I would think that choices need to be made

Princip(al)ly: the choice to reuse an existing package name was FiloSottile's, for the sake of a pun. Much as I like bad puns, I think that's rather rude. It's not hard to search for free package names, e.g., [0].

that this one would not annoy a lot.

Technically: it would silently replace users' games with some encryption tool. That's problematic even if those users are few.

Similarly: had the game been added after this ‘passage’, I would have grumpily agreed to ‘passage-game’ :-) But it wasn't.

But: I think your ’pass-age’ solution is perfect. Thanks! FiloSottile should consider it.

Kind regards,

T G-R

[0]: https://repology.org/project/passage/versions

signature.asc
Description: PGP signature

--- End Message ---