bug#58345: closed ([PATCH 0/3] Customize PS1 on foreign distributions)

[GNU bug Tracking System]

Your message dated Fri, 07 Oct 2022 08:28:56 -0400
with message-id <871qrj7r7b.fsf@gmail.com>
and subject line Re: [bug#58345] [PATCH 3/3] guix-install.sh: Add Bash prompt 
customization option.
has caused the debbugs.gnu.org bug report #58345,
regarding [PATCH 0/3] Customize PS1 on foreign distributions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
58345: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58345
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] Customize PS1 on foreign distributions
>
>
>
>
> Date: 
>
> Fri,  7 Oct 2022 01:27:38 -0400
>
>
>
>
> Hi!
>
> The following fixes a usability issue, which is that users entering 'guix
> shell' or 'guix environment' would not have any visual feedback in the prompt
> about where they are.  I've tested it on three different foreign
> distributions, and it worked well on all of them.
>
> Thanks,
>
> Maxim Cournoyer (3):
>   guix-install.sh: Improve prompt_yes_no procedure.
>   guix-install.sh: Introduce 'die' utility function.
>   guix-install.sh: Add Bash prompt customization option.
>
>  etc/guix-install.sh | 69 +++++++++++++++++++++++++++++++--------------
>  1 file changed, 48 insertions(+), 21 deletions(-)
>
> -- 
> 2.37.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#58345] [PATCH 3/3] guix-install.sh: Add Bash prompt customization option.
>
>
>
>
> Date: 
>
> Fri, 07 Oct 2022 08:28:56 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hello,
>
> zimoun <zimon.toutoune@gmail.com> writes:
>
> > Hi Maxim,
> >
> > On ven., 07 oct. 2022 at 01:32, Maxim Cournoyer <maxim.cournoyer@gmail.com> 
> > wrote:
> >> * etc/guix-install.sh (sys_customize_bashrc): New function.
> >> (main): Use it.
> >
> > Nice idea!
> >
> >> +sys_customize_bashrc()
> >> +{
> >> +    prompt_yes_no "Customize users Bash shell prompt for Guix?" || return
> >> +    for bashrc in /home/*/.bashrc /root/.bashrc; do
> >> +        test -f "$bashrc" || continue
> >> +        grep -Fq '$GUIX_ENVIRONMENT' "$bashrc" && continue
> >> +        cp "${bashrc}" "${bashrc}.bak"
> >> +        echo '
> >
> > Maybe comment, something like:
> >
> > # Automatically added by Guix install script
> >> +if [ -n "$GUIX_ENVIRONMENT" ]; then
> >> +    if [[ $PS1 =~ (.*)"\\$" ]]; then
> >> +        PS1="${BASH_REMATCH[1]} [env]\\\$ "
> >> +    fi
> >> +fi
> >> +' >> "$bashrc"
> >> +    done
> >> +    _msg "${PAS}Bash shell prompt successfully customized for Guix"
> >> +}
>
> Good idea!  Applied, like:
>
> @@ -575,6 +575,7 @@ sys_customize_bashrc()
>          grep -Fq '$GUIX_ENVIRONMENT' "$bashrc" && continue
>          cp "${bashrc}" "${bashrc}.bak"
>          echo '
> +# Automatically added by the Guix install script.
>  if [ -n "$GUIX_ENVIRONMENT" ]; then
>      if [[ $PS1 =~ (.*)"\\$" ]]; then
>          PS1="${BASH_REMATCH[1]} [env]\\\$ "
>
> >
> > LGTM!
>
> Alright, the series have been pushed to master, and the script available
> at https://guix.gnu.org/install.sh should soon reflect the changes.
>
> Thanks for reviewing!
>
> -- 
> Maxim
>
>
> --- End Message ---