bug#57945: closed ([PATCH] gnu: wpa-supplicant: enable OWE support)

[GNU bug Tracking System]

Your message dated Wed, 28 Sep 2022 22:41:34 +0200
with message-id <875yh7fczl.fsf_-_@gnu.org>
and subject line Re: bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
has caused the debbugs.gnu.org bug report #57945,
regarding [PATCH] gnu: wpa-supplicant: enable OWE support
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57945: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57945
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: wpa-supplicant: enable OWE support
>
>
>
>
> Date: 
>
> Tue, 20 Sep 2022 01:59:56 +0200
>
>
>
>
> With OWE support users are enable to connect to "Opportunistic Wireless
> Encryption" networks. This means users are able to have an encrypted
> data channel in an otherwise open wireless network.
>
> * gnu/packages/admin.scm (wpa-supplicant): Enable OWE support.
>
> Signed-off-by: Andreas Rammhold <andreas@rammhold.de>
> ---
>  gnu/packages/admin.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 5fb621e027..84819992c4 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -51,6 +51,7 @@
>  ;;; Copyright ?? 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
>  ;;; Copyright ?? 2022 Wamm K. D. <jaft.r@outlook.com>
>  ;;; Copyright ?? 2022 Roman Riabenko <roman@riabenko.com>
> +;;; Copyright ?? 2022 Andreas Rammhold <andreas@rammhold.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -2133,6 +2134,12 @@ (define-public wpa-supplicant
>        CONFIG_CTRL_IFACE_DBUS_INTRO=y\n" port)
>                   (close-port port))
>                 #t))
> +           (add-after 'configure 'enable-owe
> +             (lambda _
> +               (let ((port (open-file ".config" "al")))
> +                 (display "CONFIG_OWE=y\n" port)
> +                 (close-port port))
> +               #t))
>            (add-after 'install-documentation 'install-dbus-conf
>              (lambda* (#:key outputs #:allow-other-keys)
>                (let* ((out (assoc-ref outputs "out"))
>
> base-commit: d845326b5cb33453a50b9c8fd8f21dfd8198a158
> prerequisite-patch-id: b830a1b0573b55d8a8378338862dc5bfaac53117
> prerequisite-patch-id: 59289da7b58eb3a1ea1f3b531261d0785b58dd36
> prerequisite-patch-id: a761f12c1d69204330e6215a26ea110c281ea834
> prerequisite-patch-id: fcc87d0b44e2c3597e9270e6d96c8f1e4beddcf6
> -- 
> 2.37.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
>
>
>
>
> Date: 
>
> Wed, 28 Sep 2022 22:41:34 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Maxime Devos <maximedevos@telenet.be> skribis:
>
> > On 20-09-2022 01:59, Andreas Rammhold wrote:
> >> +           (add-after 'configure 'enable-owe
> >> +             (lambda _
> >> +               (let ((port (open-file ".config" "al")))
> >> +                 (display "CONFIG_OWE=y\n" port)
> >> +                 (close-port port))
> >> +               #t))
> >
> >
> > (1) Why not do this in the 'configure' phase instead?
> > (2) Trailing #t in phases aren't required anymore since a long time,
> > you can remove them.
> > (3) You are not a committer (and you are the author), so you can't
> > 'push the commit on behalf on somebody else'.  From (guix)Commit
>
> Good points (perhaps somewhat intimidating for a newcomer).
>
> Andreas, I applied a variant of the patch that accounts for the comments
> Maxime made.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---