--- Begin Message ---
|
Subject: |
[PATCH] Ensure `byte-compile-dest-file-function' is used |
|
Date: |
Fri, 23 Sep 2022 13:24:24 +0100 |
|
User-agent: |
Roundcube Webmail/1.4.12 |
The attached `git format-patch` is based on automake v1.16.5 and fixes
the following warning
Warning (bytecomp): byte-compile-dest-file is obsolete (as of 23.2);
Set byte-compile-dest-file-function instead.
The solution is to ensure bytecomp is loaded which defines
byte-compile-dest-file-function so it can be used when available,
and fallback to the original byte-compile-dest-file for earlier
GNU Emacs and XEmacs.
So far I've tested the result on
* CentOS 7.9 (distro emacs 24.3)
* OpenBSD 7.1 (custom emacs 28.2)
* OpenSUSE Leap 15.4 (distro emacs 27.2, xemacs 21.5)
and the warning is no longer generated.
0001-Ensure-byte-compile-dest-file-function-is-used-when-.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#58025: [PATCH] Ensure `byte-compile-dest-file-function' is used |
|
Date: |
Mon, 26 Sep 2022 10:15:48 -0600 |
Hi Richard - I installed the -l bytecomp patch you sent (copied below).
It seems safe, and good in any case. Thanks.
If there are changes to make in the -Q / -q area, let's address those
separately. (I'll close this bug, I guess, but fine to keep discussing
wherever.) I don't think Automake uses -Q now?
Since the release of 1.16.5, there has been one change already, to pass
--no-site-file (as you can see below; I'll attach the current lisp.am
for possible convenience). From your research, I guess that should be
changed to -no-site-file (one hyphen)? Where is it that the
double-hyphen --no... fails?
In general, it is definitely necessary to support Emacs 21 (I use it :).
I'm not sure if we absolutely have to support 18 or 19, but when
possible, it is certainly desirable. --thanks, karl.
* lib/am/lisp.am (.el.elc): Require the bytecomp library so
byte-compile-dest-file-function can be used when available.
diff --git a/lib/am/lisp.am b/lib/am/lisp.am
index 6395ef389..500e2c530 100644
--- a/lib/am/lisp.am
+++ b/lib/am/lisp.am
@@ -41,6 +41,7 @@ endif %?INSTALL%
$(EMACS) --batch --no-site-file \
$(AM_ELCFLAGS) $(ELCFLAGS) \
$$am__subdir_includes -L $(builddir) -L $(srcdir) \
+ -l bytecomp \
--eval '$(am__emacs_byte_compile_setup)' \
-f batch-byte-compile '$<'; \
else :; fi
lisp.am
Description: Binary data
--- End Message ---