bug#57760: closed ([PATCH] system: install: Do not load amdgpu in the installer image.)

[GNU bug Tracking System]

Your message dated Fri, 16 Sep 2022 10:16:19 +0200
with message-id <87pmfvhgz0.fsf@gnu.org>
and subject line Re: bug#57760: [PATCH] system: install: Do not load amdgpu in 
the installer image.
has caused the debbugs.gnu.org bug report #57760,
regarding [PATCH] system: install: Do not load amdgpu in the installer image.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
57760: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57760
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] system: install: Do not load amdgpu in the installer image.
>
>
>
>
> Date: 
>
> Tue, 13 Sep 2022 02:42:48 +0000
>
>
>
>
> * gnu/system/install.scm (installation-os): Add amdgpu to
> modprobe.blacklist.
> ---
> Booting the installer OS will fail when it fails to load blobs for amdgpu.
> This will allow the installer OS to boot on systems with affected hardware.
>
>  gnu/system/install.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/system/install.scm b/gnu/system/install.scm
> index a7b7c246bf..003c49a3e7 100644
> --- a/gnu/system/install.scm
> +++ b/gnu/system/install.scm
> @@ -476,7 +476,7 @@ (define installation-os
>      ;; non-functional:
>      ;; <https://lists.gnu.org/archive/html/guix-devel/2019-03/msg00441.html>.
>      ;; Thus, blacklist it.
> -    (kernel-arguments '("quiet" "modprobe.blacklist=radeon"))
> +    (kernel-arguments '("quiet" "modprobe.blacklist=radeon,amdgpu"))
>  
>      (file-systems
>       ;; Note: the disk image build code overrides this root file system with
> -- 
> 2.37.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#57760: [PATCH] system: install: Do not load amdgpu in the installer image.
>
>
>
>
> Date: 
>
> Fri, 16 Sep 2022 10:16:19 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hey Florian,
>
> Thanks for sharing your thoughts.
>
> > What Denis 'GNUtoo' Carikli wrote at
> > <https://issues.guix.gnu.org/36786#9> indicates that non-3d graphics
> > works for some radeon/amdgpu GPUs, because the code that prevents
> > booting could be removed from linux-libre for these GPUs.  If so (and it
> > didn’t work for one GPU of mine even though it is listed as freed at
> > libreplanet), these amdgpu ones would get a lower screen resolution from
> > uvesafb if this patch were added.  But it is worth the trade-off.
>
> Agreed.
>
> > Back then when we blacklisted radeon, we chose to wait for a report of
> > amdgpu not working instead of adding amdgpu to the blacklist right away.
> > Maybe booting is not broken there?
>
> Yeah, plus the corresponding hardware is way less common. So let's
> proceed with this patch as-is. Pushed as
> d0376f6718b57be90b2f7697c90e4ecbe0090e0f.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---