bug#56813: closed ([PATCH 0/2] Add a test for qemu-guest-agent service)

[GNU bug Tracking System]

Your message dated Tue, 09 Aug 2022 17:23:38 +0200
with message-id <87h72l5tl1.fsf@gnu.org>
and subject line Re: bug#56813: [PATCH 0/2] Add a test for qemu-guest-agent 
service
has caused the debbugs.gnu.org bug report #56813,
regarding [PATCH 0/2] Add a test for qemu-guest-agent service
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56813: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56813
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Add a test for qemu-guest-agent service
>
>
>
>
> Date: 
>
> Thu, 28 Jul 2022 16:57:55 +0200
>
>
>
>
> Hi,
>
> these patches fix some issues with the QEMU guest agent service, and add
> a system test for it. The test runs the service in a marionette VM and
> tries communicating with it. For that, I enabled the guest agent serial
> device in marionette QEMU options. This change touches all system tests,
> but should be harmless.
>
> I’m not sure if it would be better instead to add a keyword argument to
> make-marionette for (extra) extra QEMU options. In any case, all tests
> that pass on master still pass after this change, at least on x86_64
> (most installation tests currently fail here).
>
> Please let me know if I should change or improve anything. Thanks!
>
> Timotej Lazar (2):
>   services: qemu-guest-agent: Fix arguments to qemu-ga.
>   tests: Add qemu-guest-agent system test.
>
>  gnu/build/marionette.scm        |  5 +-
>  gnu/services/virtualization.scm | 12 ++---
>  gnu/tests/virtualization.scm    | 84 +++++++++++++++++++++++++++++++++
>  3 files changed, 93 insertions(+), 8 deletions(-)
>
> -- 
> 2.36.1
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#56813: [PATCH 0/2] Add a test for qemu-guest-agent service
>
>
>
>
> Date: 
>
> Tue, 09 Aug 2022 17:23:38 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi Timotej,
>
> Timotej Lazar <timotej.lazar@araneo.si> skribis:
>
> > these patches fix some issues with the QEMU guest agent service, and add
> > a system test for it. The test runs the service in a marionette VM and
> > tries communicating with it. For that, I enabled the guest agent serial
> > device in marionette QEMU options. This change touches all system tests,
> > but should be harmless.
>
> Yes, sounds good.
>
> > I’m not sure if it would be better instead to add a keyword argument to
> > make-marionette for (extra) extra QEMU options. In any case, all tests
> > that pass on master still pass after this change, at least on x86_64
> > (most installation tests currently fail here).
>
> Perfect.
>
> >   services: qemu-guest-agent: Fix arguments to qemu-ga.
> >   tests: Add qemu-guest-agent system test.
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---