bug#55619: closed ([PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL.)

[GNU bug Tracking System]

Your message dated Sun, 05 Jun 2022 03:12:06 +0200
with message-id <87tu8zhpnu@nckx>
and subject line Re: [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL.
has caused the debbugs.gnu.org bug report #55619,
regarding [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55619: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55619
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL.
>
>
>
>
> Date: 
>
> Wed, 25 May 2022 01:44:59 +0000
>
>
>
>
> * gnu/packages/sml.scm (smlnj): Fix use of Ctrl-c in sml REPL.
> ---
> Related mailing list thread:
> https://lists.gnu.org/archive/html/guix-devel/2022-05/msg00209.html
> ("Why does sh in the build environment ignore SIGINT and SIGQUIT?")
>
>
>  gnu/packages/sml.scm | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/sml.scm b/gnu/packages/sml.scm
> index 04411c02c3..94a65961d6 100644
> --- a/gnu/packages/sml.scm
> +++ b/gnu/packages/sml.scm
> @@ -175,10 +175,22 @@ function interface, and a symbolic debugger.")
>                         
> "sml.boot.amd64-unix/SMLNJ-BASIS/.cm/amd64-unix/basis-common.cm"))
>  
>               ;; Build.
> -             (invoke "./config/install.sh" "-default"
> -                     (if (string=? "i686-linux" ,(%current-system))
> -                       "32"
> -                       "64"))
> +             ;; The `sml` executable built by this package somehow inherits the
> +             ;; signal dispositions of the shell where it was built. If SIGINT
> +             ;; is ignored in the shell, the resulting `sml` will also ignore
> +             ;; SIGINT. This will break the use of Ctrl-c for interrupting
> +             ;; execution in the SML/NJ REPL.
> +             ;; Here, we use Guile's `system` procedure instead of Guix's
> +             ;; `invoke` because `invoke` uses Guile's `system*`, which causes
> +             ;; SIGINT and SIGQUIT to be ignored.
> +             (let ((exit-code
> +                     (system (string-append "./config/install.sh -default "
> +                                            (if (string=? "i686-linux"
> +                                                          ,(%current-system))
> +                                              "32"
> +                                              "64")))))
> +               (unless (zero? exit-code)
> +                 (error (format #f "Exit code: ~a" exit-code))))
>  
>               ;; Undo the binary patch.
>               (for-each
>
> base-commit: d129d962e437fd215c5e9428fc1b26e2d72ffbda
> -- 
> 2.25.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [PATCH] gnu: smlnj: Fix use of Ctrl-c in sml REPL. Date: Sun, 05 Jun 2022 03:12:06 +0200

Hi!

Thanks for the patch and the perfect comment.

The only thing I tweaked was the commit message, to reflect the ‘what’ rather than (just) the ‘why’:

   * gnu/packages/sml.scm (smlnj): Replace INVOKE with SYSTEM
   which has more favourable signal dispositions.

Tested on a Guix System that could reproduce the original bug & pushed as 62da327848311a75723f16642c20d2925919237e.

Kind regards,

T G-R

signature.asc
Description: PGP signature

--- End Message ---