bug#51869: closed ([PATCH] Add emacs-vala-mode)

[GNU bug Tracking System]

Your message dated Wed, 17 Nov 2021 18:09:53 +0100
with message-id <3df08e59131fca25380c16ac697ef45076257b6b.camel@gmail.com>
and subject line Re: [PATCH] Add emacs-vala-mode
has caused the debbugs.gnu.org bug report #51869,
regarding [PATCH] Add emacs-vala-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51869: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51869
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add emacs-vala-mode Date: Mon, 15 Nov 2021 14:05:46 +0000

Dear guix,

There’s a vala mode for emacs. It is not very useful, but it registers a
major mode that is then used as a placeholder for the Emacs Language
Server Protocol client. In fact, it’s not possible to activate Vala
support for LSP on emacs without a vala mode, and this is the only
implementation I know.

This is the result of importing from MELPA. The project is not very well
maintained, so it fails to build on a recent emacs (see
https://github.com/rrthomas/vala-mode/issues/14). Since I don’t have a
solution to fix this issue, I went away and reverted the multiline
support. It builds and is useful enough for LSP to kick in, so I
consider it fixed.

What do you think? Do you have a better fix?

Best regards,

Vivien

0001-gnu-Add-emacs-vala-mode.patch
Description: Add emacs-vala-mode

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] Add emacs-vala-mode
>
>
>
>
> Date: 
>
> Wed, 17 Nov 2021 18:09:53 +0100
>
>
>
>
> User-agent: 
>
> Evolution 3.34.2 
>
>
>
>
> Hi,
>
> Am Dienstag, den 16.11.2021, 19:48 +0000 schrieb Vivien Kraus:
> > > > +               (emacs-substitute-sexps "vala-mode.el"
> > > > +                 (";; Support multiline strings" 'disabled.)
> > > > +                 ("(defcustom vala-multiline-strings nil"
> > > > +                  "This variable is ignored.")))))))
> > > This inserts mostly bogus into the file rather than killing the
> > > sexps
> > > as it should.  
> > 
> > The first substitution fully kills the whole sexp (and inserts a
> > comment that reads "Support for multiline strings disabled." if you
> > don’t read too closely ^^). 
> That was too sneaky for me :P
>
> > It’s true that the second does not kill the defcustom expansion, but
> > since it’s part of the intended public API, I’m not so sure we should
> > remove it altogether. I think it’s clearer for the user that way,
> > because the two modifications are kind of documented in the source.
> > 
> > Also, it’s shorter.
> I'm pretty sure you can still use vala-multiline-strings inside a
> custom-set-variables form, it will just do nothing as it ought to.  
>
> > Anyway, Here are the two versions, you decide.
> I rewrote your batch-edit version to be a little clearer and to leave
> documented FIXMEs in the code.  I pushed the rewrite, so you should now
> be able to use emacs-vala-mode, with or without lsp.
>
> Cheers
>
>
>
> --- End Message ---