bug#51425: closed (Invalid <file-system> flags lead to a crash when booting)

[GNU bug Tracking System]

Your message dated Sun, 07 Nov 2021 23:16:17 +0100
with message-id <878rxzk3wu.fsf@gnu.org>
and subject line Re: bug#51425: file-system: validate flags
has caused the debbugs.gnu.org bug report #51425,
regarding Invalid <file-system> flags lead to a crash when booting
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51425: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51425
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> file-system: validate flags
>
>
>
>
> Date: 
>
> Wed, 27 Oct 2021 00:24:28 +0200
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.15.0
>
>
>
>
> Imagine the following file system definition in your config.scm:
>
> ```
> (file-system
>   (device (uuid "UUID-123"))
>   (flags '((create-mount-point? #t)))
>   (mount-point "/mnt")
>   (type "ext4")))
> ```
>
> When you reconfigure there will be no complain, but when you reboot your
> system wont boot. The parameter to flags is nonsense, it should be
> something like: `read-only`. So mounting of the file system will fail...
>
> It would be nice if we can have some flag validation during reconfigure.
>
> ~Jonathan
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#51425: file-system: validate flags
>
>
>
>
> Date: 
>
> Sun, 07 Nov 2021 23:16:17 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > Jonathan Brielmaier <jonathan.brielmaier@web.de> skribis:
> >
> >> Imagine the following file system definition in your config.scm:
> >>
> >> ```
> >> (file-system
> >>   (device (uuid "UUID-123"))
> >>   (flags '((create-mount-point? #t)))
> >>   (mount-point "/mnt")
> >>   (type "ext4")))
> >> ```
> >>
> >> When you reconfigure there will be no complain, but when you reboot your
> >> system wont boot.
> >
> > I suppose it fails to boot because of a match error in
> > ‘mount-flags->bit-mask’, right?
> >
> >> The parameter to flags is nonsense, it should be something like:
> >> `read-only`. So mounting of the file system will fail...
> >
> > That’s a good use case for the recently-added ‘sanitize’ record field
> > property.
>
> Done in 5eb5c0789f34e87ee417a53ddfcfa3b6521bb337.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---