emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50275: closed ([PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.)


From: GNU bug Tracking System
Subject: bug#50275: closed ([PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.)
Date: Mon, 30 Aug 2021 18:58:02 +0000

Your message dated Mon, 30 Aug 2021 14:57:30 -0400
with message-id <87wno2lq05.fsf@gmail.com>
and subject line Re: bug#50275: [PATCH 1/4] gnu: Add 
go-github-com-gdamore-tcell-v2.
has caused the debbugs.gnu.org bug report #50275,
regarding [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50275: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50275
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2. Date: Mon, 30 Aug 2021 12:40:38 -0400
From: Guix Together <jgart@dismail.de>

* gnu/packages/golang.scm (go-github-com-gdamore-tcell-v2): New variable.

Co-authored-by: Arun Isaac <arunisaac@systemreboot.net>
Co-authored-by: Brice Waegeneire <brice@waegenei.re>
Co-authored-by: jgart <jgart@dismail.de>
Co-authored-by: Julien Lepiller <julien@lepiller.eu>
---
 gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72579d6bd2..f52343345b 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -5257,6 +5257,38 @@ formatting.  It also favors portability, and includes 
support for all POSIX
 systems.")
       (license license:expat))))
 
+(define-public go-github-com-gdamore-tcell-v2
+    (package
+      (inherit go-github-com-gdamore-tcell)
+      (name "go-github-com-gdamore-tcell")
+      (version "2.3.1")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/gdamore/tcell";)
+               (commit (string-append "v" version))))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0ypbl5080q9sd3irad8mv7zlg4242i8pmg5xyhbyq95kymwibaid"))))
+      (arguments
+       `(#:import-path "github.com/gdamore/tcell/v2"
+         #:phases
+         (modify-phases %standard-phases
+           (add-before 'reset-gzip-timestamps 'make-files-writable
+             (lambda* (#:key outputs #:allow-other-keys)
+               ;; Make sure .gz files are writable so that the
+               ;; 'reset-gzip-timestamps' phase can do its work.
+               (let ((out (assoc-ref outputs "out")))
+                 (for-each make-file-writable
+                           (find-files out "\\.gz$"))
+                 #t))))))
+      (propagated-inputs
+       `(("go-golang-org-x-term" ,go-golang-org-x-term)
+         ("go-golang-org-x-sys" ,go-golang-org-x-sys)
+         ,@(package-inputs go-github-com-gdamore-tcell)))))
+
 (define-public go-github-com-mattn-go-shellwords
   (let ((commit "2444a32a19f450fabaa0bb3e96a703f15d9a97d2")
         (version "1.0.5")
-- 
2.33.0




--- End Message ---
--- Begin Message --- Subject: Re: bug#50275: [PATCH 1/4] gnu: Add go-github-com-gdamore-tcell-v2. Date: Mon, 30 Aug 2021 14:57:30 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hello!

jgart <jgart@dismail.de> writes:

> From: Guix Together <jgart@dismail.de>
>
> * gnu/packages/golang.scm (go-github-com-gdamore-tcell-v2): New variable.
>
> Co-authored-by: Arun Isaac <arunisaac@systemreboot.net>
> Co-authored-by: Brice Waegeneire <brice@waegenei.re>
> Co-authored-by: jgart <jgart@dismail.de>
> Co-authored-by: Julien Lepiller <julien@lepiller.eu>

This is awesome!

> ---
>  gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index 72579d6bd2..f52343345b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -5257,6 +5257,38 @@ formatting.  It also favors portability, and includes 
> support for all POSIX
>  systems.")
>        (license license:expat))))
>  
> +(define-public go-github-com-gdamore-tcell-v2
> +    (package
> +      (inherit go-github-com-gdamore-tcell)
> +      (name "go-github-com-gdamore-tcell")
> +      (version "2.3.1")
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/gdamore/tcell";)
> +               (commit (string-append "v" version))))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0ypbl5080q9sd3irad8mv7zlg4242i8pmg5xyhbyq95kymwibaid"))))
> +      (arguments
> +       `(#:import-path "github.com/gdamore/tcell/v2"
> +         #:phases
> +         (modify-phases %standard-phases
> +           (add-before 'reset-gzip-timestamps 'make-files-writable
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               ;; Make sure .gz files are writable so that the
> +               ;; 'reset-gzip-timestamps' phase can do its work.
> +               (let ((out (assoc-ref outputs "out")))
> +                 (for-each make-file-writable
> +                           (find-files out "\\.gz$"))
> +                 #t))))))

Note that you can preemptively start loosing the trailing #t; the
warning will vanish after the guix-core-updates-frozen branch is merged
into master.

> +      (propagated-inputs
> +       `(("go-golang-org-x-term" ,go-golang-org-x-term)
> +         ("go-golang-org-x-sys" ,go-golang-org-x-sys)
> +         ,@(package-inputs go-github-com-gdamore-tcell)))))
> +
>  (define-public go-github-com-mattn-go-shellwords
>    (let ((commit "2444a32a19f450fabaa0bb3e96a703f15d9a97d2")
>          (version "1.0.5")

LGTM.  I fixed the license of the parent package (it should have been
Apache 2.0) and pushed as cc71a54e9f900e905192f794c7bc5346c445e651.

Closing.

Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]