bug#50281: closed ([RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx.)

[GNU bug Tracking System]

Your message dated Mon, 30 Aug 2021 14:26:11 -0400
with message-id <87k0k2n60s.fsf@gmail.com>
and subject line Re: bug#50281: [RFC PATCH] build/jami-service: Fix range ends 
in account-fingerprint-rx.
has caused the debbugs.gnu.org bug report #50281,
regarding [RFC PATCH] build/jami-service: Fix range ends in 
account-fingerprint-rx.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50281: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50281
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx.
>
>
>
>
> Date: 
>
> Mon, 30 Aug 2021 19:39:35 +0200
>
>
>
>
> This broke compilation of Guix with guile@3.0.2 with:
>
>   In procedure make-regexp: Invalid range end
>
> The fix is to replace [0-9A-f] with [0-9A-Fa-f].
> TODO: were both uppercase and lowercase intended, or
> only one of the two?
>
> * gnu/build/jami-service.scm
>   (account-fingerprint-rx): Correct regexp.
> ---
>  gnu/build/jami-service.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm
> index d44e87387d..ddfc8cf937 100644
> --- a/gnu/build/jami-service.scm
> +++ b/gnu/build/jami-service.scm
> @@ -96,7 +96,7 @@ before each retry."
>                   (list key value)))
>                alist))
>  
> -(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}"))
> +(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}"))
>  
>  (define (account-fingerprint? val)
>    "A Jami account fingerprint is 40 characters long and only contains
> -- 
> 2.33.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#50281: [RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx.
>
>
>
>
> Date: 
>
> Mon, 30 Aug 2021 14:26:11 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Maxime,
>
> Maxime Devos <maximedevos@telenet.be> writes:
>
> > This broke compilation of Guix with guile@3.0.2 with:
> >
> >   In procedure make-regexp: Invalid range end
>
> Uh, good catch!  Makes me curious to know what was changed in 3.0.7!
>
> > The fix is to replace [0-9A-f] with [0-9A-Fa-f].
> > TODO: were both uppercase and lowercase intended, or
> > only one of the two?
>
> Yes, Jami does not care about the case of the Jami account fingerprint
> (IIRC).  I've now edited out the TODO.
>
> > * gnu/build/jami-service.scm
> >   (account-fingerprint-rx): Correct regexp.
> > ---
> >  gnu/build/jami-service.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm
> > index d44e87387d..ddfc8cf937 100644
> > --- a/gnu/build/jami-service.scm
> > +++ b/gnu/build/jami-service.scm
> > @@ -96,7 +96,7 @@ before each retry."
> >                   (list key value)))
> >                alist))
> >  
> > -(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}"))
> > +(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}"))
> >  
> >  (define (account-fingerprint? val)
> >    "A Jami account fingerprint is 40 characters long and only contains
>
> And pushed as a3bfe953d2.
>
> Thank you!
>
> Closing,
>
> Maxim
>
>
> --- End Message ---