bug#19711: closed (25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)))

[GNU bug Tracking System]

Your message dated Mon, 16 Aug 2021 13:39:31 -0400
with message-id <jwv5yw5z3vx.fsf-monnier+emacsbugs@gnu.org>
and subject line Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent 
with (advice--p (advice--symbol-function sym))
has caused the debbugs.gnu.org bug report #19711,
regarding 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p 
(advice--symbol-function sym))
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
19711: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19711
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym))
>
>
>
>
> Date: 
>
> Wed, 28 Jan 2015 14:55:01 +0100
>
>
>
>
> `ad-is-adviced' expands to:
>
>     (get 'foo 'ad-advice-info)
>
> This code will not detect if the function `foo' is being instrumented
> with `elp-instrument-package' (which is a form of advice).
>
> On the other hand, this code from `advice-remove' will work:
>
>     (advice--p (advice--symbol-function 'foo))
>
> To summarize, functions instrumented by elp aren't recognized as adviced
> by `ad-is-advised', even though :around advice: even shows up in the
> docstring.
>
> A fix could be to change `ad-is-adviced' to expand to either
>
>     (or (get 'foo 'ad-advice-info)
>         (get 'foo 'elp-info))
>
> or
>
>     (advice--p (advice--symbol-function 'foo))
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym))
>
>
>
>
> Date: 
>
> Mon, 16 Aug 2021 13:39:31 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> > I think this was basically fixed by:
> >
> > commit 6e2d6d54e1236216462c13655ea1fe573d9672e7
> > Author:     Stefan Monnier <monnier@iro.umontreal.ca>
> > AuthorDate: Fri Jul 14 11:27:21 2017 -0400
>
> Agreed, closing,
>
>
>         Stefan
>
>
>
> --- End Message ---