emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41790: closed ([PATCH] Update emacs-direnv)


From: GNU bug Tracking System
Subject: bug#41790: closed ([PATCH] Update emacs-direnv)
Date: Fri, 06 Aug 2021 04:50:02 +0000

Your message dated Fri, 06 Aug 2021 00:49:52 -0400
with message-id <87sfznjhxr.fsf_-_@gmail.com>
and subject line Re: bug#41790: [PATCH] Update emacs-direnv
has caused the debbugs.gnu.org bug report #41790,
regarding [PATCH] Update emacs-direnv
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
41790: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41790
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] Update emacs-direnv Date: Wed, 10 Jun 2020 10:12:03 -0500
10:11 kate says: guix refresh -l emacs-direnv
No dependents other than itself: emacs-direnv@2.0.0

Attachment: 0001-gnu-emacs-direnv-Update-to-2.1.0.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#41790: [PATCH] Update emacs-direnv Date: Fri, 06 Aug 2021 00:49:52 -0400 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hello,

Katherine Cox-Buday <cox.katherine.e@gmail.com> writes:

[...]

>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-in-direnv
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((direnv-path (assoc-ref inputs "direnv"))
> +                    (direnv-bin (string-append
> +                                 "\"" direnv-path "/bin/direnv\"")))
> +               (substitute* "direnv.el"
> +                 (("\"direnv\"") direnv-bin))))))))
> +    (inputs
> +     `(("direnv" ,direnv)))
>      (propagated-inputs
>       `(("dash" ,emacs-dash)
>         ("with-editor" ,emacs-with-editor)))

Thanks to Nicolas and Oleg for the thoughtful review.  They had good
comments about was propagation was not the best way to make the package
usable out of the box.  Now that the above does the same but in a
functional way, I think it is a good addition.

I applied the above hunk (the package had already been updated) as
commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b.

Thank you!

Closing.

Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]