bug#44663: closed ([PATCH] ui: Launch $PAGER through the shell.)

[GNU bug Tracking System]

Your message dated Tue, 03 Aug 2021 16:02:56 -0400
with message-id <87lf5i8ff3.fsf_-_@gmail.com>
and subject line Re: bug#44663: [PATCH] ui: Launch $PAGER through the shell.
has caused the debbugs.gnu.org bug report #44663,
regarding [PATCH] ui: Launch $PAGER through the shell.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44663: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44663
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] ui: Launch $PAGER through the shell.
>
>
>
>
> Date: 
>
> Sun, 15 Nov 2020 19:47:26 +0100
>
>
>
>
> This is the convention elsewhere and sounds like the right thing to do.
>
> * guix/ui.scm (call-with-paginated-output-port): Substitute OPEN-PIPE
> for OPEN-PIPE*.
>
> Reported by Daniel Brooks <db48x@db48x.net>.
> ---
>  guix/ui.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/guix/ui.scm b/guix/ui.scm
> index 4e686297e8..2b7d9dd64b 100644
> --- a/guix/ui.scm
> +++ b/guix/ui.scm
> @@ -72,7 +72,7 @@
>    #:use-module (ice-9 match)
>    #:use-module (ice-9 format)
>    #:use-module (ice-9 regex)
> -  #:autoload   (ice-9 popen) (open-pipe* close-pipe)
> +  #:autoload   (ice-9 popen) (open-pipe close-pipe)
>    #:autoload   (system base compile) (compile-file)
>    #:autoload   (system repl repl)  (start-repl)
>    #:autoload   (system repl debug) (make-debug stack->vector)
> @@ -1673,9 +1673,9 @@ zero means that PACKAGE does not match any of REGEXPS."
>        ;; instead of 'r': this strips hyperlinks but allows 'less' to make a
>        ;; good estimate of the line length.
>        (let ((pager (with-environment-variables `(("LESS" ,less-options))
> -                     (open-pipe* OPEN_WRITE
> -                                 (or (getenv "GUIX_PAGER") (getenv "PAGER")
> -                                     "less")))))
> +                     (open-pipe (or (getenv "GUIX_PAGER") (getenv "PAGER")
> +                                    "less")
> +                                OPEN_WRITE))))
>          (dynamic-wind
>            (const #t)
>            (lambda () (proc pager))
> -- 
> 2.29.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#44663: [PATCH] ui: Launch $PAGER through the shell.
>
>
>
>
> Date: 
>
> Tue, 03 Aug 2021 16:02:56 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hey,
>
> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
> > * guix/ui.scm (call-with-paginated-output-port): Empty PAGER values
> > disable paging.  Non-empty ones are split into command arguments.
> >
> > Reported by Daniel Brooks <db48x@db48x.net>.
> > ---
> >  guix/ui.scm | 47 ++++++++++++++++++++++++++++-------------------
> >  1 file changed, 28 insertions(+), 19 deletions(-)
>
> I see this got pushed with a81258c12415b9cee52c951b8b53cbe46f27654f
> about a year ago.
>
> Closing!
>
> Maxim
>
>
> --- End Message ---