--- Begin Message ---
Subject: |
[PATCH] gnu: u-boot: Update to 2021.07. |
Date: |
Tue, 13 Jul 2021 20:56:55 +0100 |
User-agent: |
mu4e 1.4.15; emacs 27.2 |
Hi Guix!
Here's a patch to update u-boot to 2021.07. I've tested this by booting
a barebone image on the pinebook pro. I've also tested it on the
rockpro64 however that still requires another fix, see bug#49550 [0]
which is an existing issue.
Thanks,
Pierre
[0]: https://lists.gnu.org/archive/html/bug-guix/2021-07/msg00225.html
signature.asc
Description: PGP signature
From 82c2422ea06013ca8914c2628cdd2569ffb43973 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Sat, 10 Jul 2021 14:12:02 +0100
Subject: [PATCH] gnu: u-boot: Update to 2021.07.
* gnu/packages/bootloaders.scm (u-boot): Update to 2021.07.
[native-inputs]: Add python-pycryptodomex.
(u-boot-2021.07): Delete variable.
(u-boot-tools)[arguments]: Adapt 'patch phase, disable failing test_spl test.
(u-boot-sifive-unmatched): Use default u-boot package.
(u-boot-pinebook-pro-rk3328): Use default u-boot package.
---
gnu/packages/bootloaders.scm | 38 +++++++++++-------------------------
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 75705a27c1..448853a7da 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -56,6 +56,7 @@
#:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages python)
+ #:use-module (gnu packages python-crypto)
#:use-module (gnu packages texinfo)
#:use-module (gnu packages tls)
#:use-module (gnu packages sdl)
@@ -496,7 +497,7 @@ tree binary files. These are board description files used
by Linux and BSD.")
(define u-boot
(package
(name "u-boot")
- (version "2021.04")
+ (version "2021.07")
(source (origin
(patches
(list %u-boot-rockchip-inno-usb-patch))
@@ -506,7 +507,7 @@ tree binary files. These are board description files used
by Linux and BSD.")
"u-boot-" version ".tar.bz2"))
(sha256
(base32
- "06p1vymf0dl6jc2xy5w7p42mpgppa46lmpm2ishmgsycnldqnhqd"))))
+ "0zm7igkdnz0w4ir8rfl2dislfrl0ip104grs5hvd30a5wkm7wari"))))
(native-inputs
`(("bc" ,bc)
("bison" ,bison)
@@ -516,6 +517,7 @@ tree binary files. These are board description files used
by Linux and BSD.")
("perl" ,perl)
("python" ,python)
("python-coverage" ,python-coverage)
+ ("python-pycryptodomex" ,python-pycryptodomex)
("python-pytest" ,python-pytest)
("swig" ,swig)))
(build-system gnu-build-system)
@@ -525,21 +527,6 @@ tree binary files. These are board description files used
by Linux and BSD.")
also initializes the boards (RAM etc).")
(license license:gpl2+)))
-(define-public u-boot-2021.07
- (package
- (inherit u-boot)
- (version "2021.07-rc4")
- (source (origin
- (patches
- (list %u-boot-rockchip-inno-usb-patch))
- (method url-fetch)
- (uri (string-append
- "https://ftp.denx.de/pub/u-boot/"
- "u-boot-" version ".tar.bz2"))
- (sha256
- (base32
- "0bnsywgy2b0jxim5h9dc807lqk5kq8hvgf4lcsmffnc0hf4isv8p"))))))
-
(define-public u-boot-tools
(package
(inherit u-boot)
@@ -568,9 +555,12 @@ also initializes the boards (RAM etc).")
;; This test would require git.
(("\\./tools/patman/patman") (which "true"))
;; FIXME: test fails, needs further investiation
- (("run_test \"binman\"") ": run_test \"binman\"")
+ (("run_test \"binman\"") "# run_test \"binman\"")
+ ;; FIXME: test_spl fails, needs further investiation
+ (("test_ofplatdata or test_handoff or test_spl")
+ "test_ofplatdata or test_handoff")
;; FIXME: code coverage not working
- (("run_test \"binman code coverage\"") ": run_test \"binman code
coverage\"")
+ (("run_test \"binman code coverage\"") "# run_test \"binman code
coverage\"")
;; This test would require internet access.
(("\\./tools/buildman/buildman") (which "true")))
(substitute* "test/py/tests/test_sandbox_exit.py"
@@ -879,11 +869,7 @@ to Novena upstream, does not load u-boot.img from the
first partition.")
(make-u-boot-package "sifive_fu540" "riscv64-linux-gnu"))
(define-public u-boot-sifive-unmatched
- (let ((base (make-u-boot-package "sifive_unmatched" "riscv64-linux-gnu")))
- (package
- (inherit base)
- (version (package-version u-boot-2021.07))
- (source (package-source u-boot-2021.07)))))
+ (make-u-boot-package "sifive_unmatched" "riscv64-linux-gnu"))
(define-public u-boot-rock64-rk3328
(let ((base (make-u-boot-package "rock64-rk3328" "aarch64-linux-gnu")))
@@ -951,9 +937,7 @@ to Novena upstream, does not load u-boot.img from the first
partition.")
(define-public u-boot-pinebook-pro-rk3399
(let ((base (make-u-boot-package "pinebook-pro-rk3399" "aarch64-linux-gnu")))
(package
- (inherit base)
- (version (package-version u-boot-2021.07))
- (source (package-source u-boot-2021.07))
+ (inherit base)
(arguments
(substitute-keyword-arguments (package-arguments base)
((#:phases phases)
--
2.32.0
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#49552: [PATCH] gnu: u-boot: Update to 2021.07. |
Date: |
Mon, 02 Aug 2021 13:31:02 +0100 |
User-agent: |
mu4e 1.6.1; emacs 27.2 |
Hi!
Vagrant Cascadian <vagrant@debian.org> writes:
> [[PGP Signed Part:Undecided]]
> On 2021-07-26, Pierre Langlois wrote:
>> Vagrant Cascadian writes:
>>
>>> On 2021-07-25, Mathieu Othacehe wrote:
>>>>> * gnu/packages/bootloaders.scm (u-boot): Update to 2021.07.
>>>>> [native-inputs]: Add python-pycryptodomex.
>>>>> (u-boot-2021.07): Delete variable.
>>>>> (u-boot-tools)[arguments]: Adapt 'patch phase, disable failing test_spl
>>>>> test.
>>>>> (u-boot-sifive-unmatched): Use default u-boot package.
>>>>> (u-boot-pinebook-pro-rk3328): Use default u-boot package.
>>>>
>>>> This seems fine to me, Vagrant any objections here?
>>>
>>> Heh. Just uploaded 2021.07 to Debian last night! Been meaning to look at
>>> updating in guix, but apparently someone beat me to it :)
>>>
>>> Overall, sounds fine to me, with one relatively minor change...
>>>
>>> u-boot-sifive-unmatched will need a pretty trivial patch in order to
>>> update to 2021.07:
>>>
>>> https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/1937246
>>>
>>> https://salsa.debian.org/debian/u-boot/-/blob/debian/latest/debian/patches/riscv64/unmatched-prevent-relocating-initrd-and-fdt.patch
>>>
>>> At least, it did when building on Debian (and apparently Ubuntu)...
>>
>> Sure, I've added the patch! I don't have any HW to test sifive unmatched
>> support though, I did test the update on a pinebookpro and rockpro64
>> when originally posting this, the new patch shouldn't affect them.
>
> I have pretty high confidence it's needed, has low risk for breaking
> other u-boot platforms, and riscv64 support in guix is pretty
> experimental at this point so I would say safe to go with it untested at
> this point... though at some point I can test it on actual hardware if
> it really is needed.
Sounds good to me!
>
>
>> That being said, while it works on pinebookpro, I still need an extra
>> patch on the rockpro64 in order to boot, both on master with u-boot
>> 2021.07 :-/ (see #49550).
>>
>> Were you able to confirm the issue? I see it looks like we have the same
>> configuration in debian and guix, CONFIG_USE_PREBOOT=y and the
>> "inno-usb" patch applied, mmmm
>
> Seems like you fixed the core of that problem in another commit!
>
> Patch looks good to me, thanks for working on it!
Thanks for the review! I've just pushed it as
eb46c6c5c81695af475f7e1e416d05e51157fe60, with a couple of tweaks to
make `guix lint' happy (the patch filename was a little too long, as
well as a line was over the column limit).
Thanks,
Pierre
signature.asc
Description: PGP signature
--- End Message ---