bug#49770: closed ([PATCH] rmailsum: error when message contains no From header)

[GNU bug Tracking System]

Your message dated Thu, 29 Jul 2021 18:41:41 +0300
with message-id <83h7gdrutm.fsf@gnu.org>
and subject line Re: bug#49770: [PATCH] rmailsum: error when message contains 
no From header
has caused the debbugs.gnu.org bug report #49770,
regarding [PATCH] rmailsum: error when message contains no From header
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49770: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49770
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] rmailsum: error when message contains no From header
>
>
>
>
> Date: 
>
> Thu, 29 Jul 2021 21:24:13 +0800
>
>
>
>
> If you open a mbox file in rmail-mode containing a message without a
> "From" header and press "h" to display the summary, the following
> error occurs:
>
>   Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>     string-match("\n" nil)
>     rmail-header-summary()
>     rmail-create-summary(1 nil nil 101)
>     rmail-create-summary-line(1)
>     rmail-get-summary(1)
>     rmail-new-summary-1("All" (rmail-summary) nil nil)
>     rmail-new-summary("All" (rmail-summary) nil)
>     rmail-summary()
>     funcall-interactively(rmail-summary)
>     call-interactively(rmail-summary nil nil)
>
> * lisp/mail/rmailsum.el (rmail-header-summary): Check if from header
> is set before scanning it for newlines.
> ---
>  lisp/mail/rmailsum.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/mail/rmailsum.el b/lisp/mail/rmailsum.el
> index 44cff21b0628..436bc78250cb 100644
> --- a/lisp/mail/rmailsum.el
> +++ b/lisp/mail/rmailsum.el
> @@ -758,7 +758,7 @@ rmail-header-summary
>                     len mch lo newline)
>                 ;; If there are multiple lines in FROM,
>                 ;; discard up to the last newline in it.
> -               (while (setq newline (string-match "\n" from))
> +               (while (and from (setq newline (string-match "\n" from)))
>                   (setq from (substring from (1+ newline))))
>                (if (or (null from)
>                        (string-match
> -- 
> 2.30.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#49770: [PATCH] rmailsum: error when message contains no From header
>
>
>
>
> Date: 
>
> Thu, 29 Jul 2021 18:41:41 +0300
>
>
>
>
> > From: Nick Gasson <nick@nickg.me.uk>
> > Date: Thu, 29 Jul 2021 21:24:13 +0800
> > Cc: Nick Gasson <nick@nickg.me.uk>
> > 
> > If you open a mbox file in rmail-mode containing a message without a
> > "From" header and press "h" to display the summary, the following
> > error occurs:
> > 
> >   Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> >     string-match("\n" nil)
> >     rmail-header-summary()
> >     rmail-create-summary(1 nil nil 101)
> >     rmail-create-summary-line(1)
> >     rmail-get-summary(1)
> >     rmail-new-summary-1("All" (rmail-summary) nil nil)
> >     rmail-new-summary("All" (rmail-summary) nil)
> >     rmail-summary()
> >     funcall-interactively(rmail-summary)
> >     call-interactively(rmail-summary nil nil)
> > 
> > * lisp/mail/rmailsum.el (rmail-header-summary): Check if from header
> > is set before scanning it for newlines.
>
> Thanks, installed (with a tiny change: I prefer an explicit 'stringp'
> test where we must have a string).
>
> This contribution was small enough for us to be able to receive it
> without a copyright assignment, but if you'd like to be able to
> contribute in the future without restrictions, I suggest to start your
> copyright assignment paperwork rolling.  If you'd like that, I will
> send you the form to fill and the instructions to go with it.
>
>
> --- End Message ---