emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#48071: closed (28.0.50: dired-guess-default: comply with docstring o


From: GNU bug Tracking System
Subject: bug#48071: closed (28.0.50: dired-guess-default: comply with docstring options [PATCH])
Date: Wed, 21 Jul 2021 23:29:01 +0000

Your message dated Thu, 22 Jul 2021 01:28:36 +0200
with message-id <87k0lj8cwr.fsf@web.de>
and subject line Re: bug#48071: 28.0.50: dired-guess-default: comply with 
docstring options [PATCH]
has caused the debbugs.gnu.org bug report #48071,
regarding 28.0.50: dired-guess-default: comply with docstring options [PATCH]
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48071: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48071
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 28.0.50: dired-guess-default: comply with docstring options [PATCH] Date: Tue, 27 Apr 2021 14:53:40 -0400 User-agent: NeoMutt/20180716
The docstring for dired-guess-default claims it should handle multiple
instances of COMMAND each of which could be a STRING or a FUNCTION which
evaluates to a STRING ...

The attached patch does that. It also weeds out strings that don't represent
valid programs on the host machine.

It turned out that function dired-guess-shell-command wasn't ready for
the multiple responses, so the patch corrects that as well.

My package diredc has an additional feature of an option for a universal
fall-back. My memory is that the emacs developers rejected the idea when
I originally proposed it, so it's not in this patch.

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Attachment: dired-guess-default.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#48071: 28.0.50: dired-guess-default: comply with docstring options [PATCH] Date: Thu, 22 Jul 2021 01:28:36 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Lars Ingebrigtsen <larsi@gnus.org> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
> > Other things changed, too: AFAIU now only one file has to match,
> > originally all had to - correct?
>
> Fixed now.

Yes - thanks.

So the (only) remaining user visible change is that now all matching
entries are considered instead of only the first one, which is actually
a fix: the docstring of `dired-guess-shell-alist-user' describes it
should work like that.

Ok, I hope we are done then ;-) and: closing again.

Thanks,

Michael.



--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]