bug#49336: closed ([PATCH] gnu: shellcheck: Generate and install manpage)

[GNU bug Tracking System]

Your message dated Fri, 02 Jul 2021 20:37:44 +0200
with message-id <8735swv8y2.fsf@nckx>
and subject line Re: [bug#49336] [PATCH] gnu: shellcheck: Generate and install 
manpage
has caused the debbugs.gnu.org bug report #49336,
regarding [PATCH] gnu: shellcheck: Generate and install manpage
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49336: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49336
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: shellcheck: Generate and install manpage
>
>
>
>
> Date: 
>
> Fri,  2 Jul 2021 14:10:02 -0400
>
>
>
>
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/haskell-apps.scm (shellcheck)
> [arguments]<#:phases>: Add build-manpage and install-manpage phases
> [native-inputs]: Add pandoc
> ---
>  gnu/packages/haskell-apps.scm | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/gnu/packages/haskell-apps.scm b/gnu/packages/haskell-apps.scm
> index af777d1e3a..59e044b424 100644
> --- a/gnu/packages/haskell-apps.scm
> +++ b/gnu/packages/haskell-apps.scm
> @@ -17,6 +17,7 @@
>  ;;; Copyright © 2020 Brian Leung <bkleung89@gmail.com>
>  ;;; Copyright © 2021 EuAndreh <eu@euandre.org>
>  ;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
> +;;; Copyright © 2021 Morgan Smith <Morgan.J.Smith@outlook.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -857,11 +858,27 @@ too slow and you'll get wound up in the scroll and 
> crushed.")
>          (base32 "06m4wh891nah3y0br4wh3adpsb16zawkb2ijgf1vcz61fznj6ps1"))
>         (file-name (string-append name "-" version ".tar.gz"))))
>      (build-system haskell-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'build 'build-manpage
> +           (lambda _
> +             ;; Run script to generate manpage
> +             (invoke "sh" "manpage")
> +             #t))
> +         (add-after 'install 'install-manpage
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "shellcheck.1"
> +                           (string-append (assoc-ref outputs "out")
> +                                          "/share/man/man1/"))
> +             #t)))))
>      (inputs
>       `(("ghc-aeson" ,ghc-aeson)
>         ("ghc-diff" ,ghc-diff)
>         ("ghc-quickcheck" ,ghc-quickcheck)
>         ("ghc-regex-tdfa" ,ghc-regex-tdfa)))
> +    (native-inputs
> +     `(("pandoc" ,pandoc)))
>      (home-page "https://www.shellcheck.net/";)
>      (synopsis "Static analysis for shell scripts")
>      (description "@code{shellcheck} provides static analysis for
> -- 
> 2.32.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#49336] [PATCH] gnu: shellcheck: Generate and install manpage Date: Fri, 02 Jul 2021 20:37:44 +0200

Morgan,

Morgan.J.Smith@outlook.com 写道：

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/haskell-apps.scm (shellcheck)

[arguments]<#:phases>: Add build-manpage and install-manpage phases

[native-inputs]: Add pandoc

Thanks!  I added full stops to some lines and pushed it.

+             #t))
+             #t)))))

I removed these as well to avoid future noise: the requirement is obsolete on core-updates, but unfortunately the warning can't be removed on master.

Kind regards,

T G-R

signature.asc
Description: PGP signature

--- End Message ---