bug#49273: closed ([PATCH 0/1] gnu: Add emacs-rustic.)

[GNU bug Tracking System]

Your message dated Fri, 02 Jul 2021 09:16:00 +0200
with message-id <87a6n5w5hr.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#49273] [PATCH 1/1] gnu: Add emacs-rustic.
has caused the debbugs.gnu.org bug report #49273,
regarding [PATCH 0/1] gnu: Add emacs-rustic.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49273: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49273
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] gnu: Add emacs-rustic.
>
>
>
>
> Date: 
>
> Tue, 29 Jun 2021 18:55:22 +0530
>
>
>
>
> Adding emacs-rustic package.
>
> Dhruvin Gandhi (1):
>   gnu: Add emacs-rustic.
>
>  gnu/packages/emacs-xyz.scm | 57 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> -- 
> 2.32.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#49273] [PATCH 1/1] gnu: Add emacs-rustic.
>
>
>
>
> Date: 
>
> Fri, 02 Jul 2021 09:16:00 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Dhruvin Gandhi via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-rustic): New variable.
>
> Thank you.
>
> I applied your patch with the following changes:
>
> > +(define-public emacs-rustic
> > +  (let ((commit "bbf129cd128105de51b6c242b2551094b8d8987d")
> > +        (revision "0"))
>
> I added a comment explaining why we're not using a specific tag here.
>
> > +           (add-before 'check 'set-without-cask
> > +             (lambda _
> > +               (setenv "WITHOUT_CASK" "1")
> > +               #t)))))
>
> I removed the #t here.
> > +      (home-page "https://github.com/brotzeit/rustic";)
> > +      (synopsis "Rust development environment for Emacs")
> > +      (description "Rustic is a fork of rust-mode.
> > +
> > +Differences with rust-mode:
> > +@itemize
> > +@item flycheck integration
> > +@item cargo popup
> > +@item multiline error parsing
> > +@item translation of ANSI control sequences through xterm-color
> > +@item async org babel
> > +@item custom compilation process
> > +@item rustfmt errors in a rust compilation mode
> > +@item automatic LSP configuration with eglot or lsp-mode
> > +@item optional rust inline documentation
> > +@item etc.
> > +@end itemize\n")
>
> I slightly reworded the description so it includes full sentences, with
> proper capitalization, and no newline character at its end.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---