bug#46680: closed ([PATCH] gnu: Add midicomp.)

[GNU bug Tracking System]

Your message dated Tue, 23 Feb 2021 20:07:50 +0100
with message-id <875z2iy54p.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#46680] [PATCH] gnu: Add midicomp.
has caused the debbugs.gnu.org bug report #46680,
regarding [PATCH] gnu: Add midicomp.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46680: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46680
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add midicomp.
>
>
>
>
> Date: 
>
> Sun, 21 Feb 2021 10:21:37 +0000
>
>
>
>
> * gnu/packages/audio.scm (midicomp): New variable.
> ---
>  gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 16e0eec418..e910c314fd 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1223,6 +1223,37 @@ object library.")
>  language and software synthesizer.")
>      (license license:lgpl2.1+)))
>  
> +(define-public midicomp
> +  ;; The latest tagged release is 9 years old and there have been
> +  ;; unreleased fixes, so we take the last commit.
> +  (let ((commit "70f76963cb0cdb3cbe03ec6e7246b1fb885d3c68")
> +        (revision "1"))
> +    (package
> +      (name "midicomp")
> +      (version (string-append "0.0.6-" revision "." (string-take commit 7)))
> +      (source
> +        (origin
> +          (method git-fetch)
> +          (uri (git-reference
> +                 (url "https://github.com/markc/midicomp";)
> +                 (commit commit)))
> +          (file-name (git-file-name name version))
> +          (sha256
> +           (base32
> +            "12zh247c6v88ssy4l8v7yirh4bl2jcc1ch7f4gdry79a82kai1gf"))))
> +     (build-system cmake-build-system)
> +     (arguments
> +      `(#:tests? #f))  ; no "check" target
> +      (synopsis "MIDI compiler")
> +      (description
> +       "midicomp can manipulate SMF (Standard MIDI File) files.  It can both
> +  read and write SMF files in 0 or format 1 and also read and write its own
> +  plain text format.  This means a SMF file can be turned into easily
> +  parseable text, edited with any text editor or filtered through any script
> +  language, and recompiled back into a binary SMF file.")
> +      (home-page "https://github.com/markc/midicomp";)
> +      (license license:agpl3))))
> +
>  (define-public clalsadrv
>    (package
>      (name "clalsadrv")
> -- 
> 2.30.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#46680] [PATCH] gnu: Add midicomp.
>
>
>
>
> Date: 
>
> Tue, 23 Feb 2021 20:07:50 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Alexandros Theodotou <alex@zrythm.org> writes:
>
> > Thanks for the feedback, I updated the patch (attached).
>
> Thank you.
>
> > I saw the conversation on IRC and I believe we should take the word of
> > the author if it's explicitly mentioned in the README.
>
> Indeed. I applied your patch with a minor fix.
>
> > +      (version (git-version "0.0.8-" revision commit))
>
> "0.0.8-"  -> "0.0.8"
>
> Regards,
>
>
> --- End Message ---