bug#45712: closed ([PATCHES] Improve Python package quality)

[GNU bug Tracking System]

Your message dated Mon, 01 Feb 2021 12:02:44 -0500
with message-id <87czxjsouj.fsf@gmail.com>
and subject line Re: bug#45712: [PATCHES] Improve Python package quality
has caused the debbugs.gnu.org bug report #45712,
regarding [PATCHES] Improve Python package quality
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45712: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45712
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCHES] Improve Python package quality Date: Thu, 7 Jan 2021 14:26:20 +0100

Hi,

as announced in
https://lists.gnu.org/archive/html/guix-devel/2021-01/msg00021.html I’ve
been working on adding an additional phase to Python packages to check
whether they actually work. I cleaned up my patch, added tests and now
I’m pretty confident it works as expected. The first patch in this
series adds this phase, while the other ones fix build failures caused
by it. All of this should go to core-updates (or a separate wip-*
branch?), since it causes a massive number of rebuilds.

You can also pull my git repo at https://github.com/PromyLOPh/guix.git
branch work-python-importcheck.

Cheers,
Lars

0001-build-system-python-Validate-installed-package.patch
Description: Text Data

0002-gnu-pytest-6-Add-missing-propagated-input.patch
Description: Text Data

0003-gnu-python-pytest-xdist-Add-missing-input-relax-pyte.patch
Description: Text Data

0004-gnu-python-fixtures-bootstrap-Do-not-apply-loadable-.patch
Description: Text Data

0005-gnu-python-pytest-pep8-Fix-package.patch
Description: Text Data

0006-gnu-python-pyfakefs-Disable-unreliable-test.patch
Description: Text Data

0007-gnu-python-slugify-Add-missing-input.patch
Description: Text Data

0008-gnu-python-websockets-Fix-Python-package-name.patch
Description: Text Data

0009-gnu-python-black-Remove-blackd.patch
Description: Text Data

0010-gnu-python-traitlets-Add-missing-input.patch
Description: Text Data

0011-gnu-python-idna-ssl-Add-missing-input.patch
Description: Text Data

0012-gnu-python-twisted-Remove-broken-console-scripts.patch
Description: Text Data

0013-gnu-python-automat-Remove-broken-console-script.patch
Description: Text Data

0014-gnu-python-packaging-bootstrap-Remove-dependency.patch
Description: Text Data

0015-gnu-python-traceback2-Add-missing-dependency.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#45712: [PATCHES] Improve Python package quality
>
>
>
>
> Date: 
>
> Mon, 01 Feb 2021 12:02:44 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hi Lars,
>
> Lars-Dominik Braun <lars@6xq.net> writes:
>
> > Hi Maxim,
> >
> >> Oh yes, sorry I had failed to mention it, this is on the
> >> cu/farewell-to-pythonpath branch, which is the integration of
> >> GUIX_PYTHONPATH and this work of yours.  I've included your v2 patches,
> >> with light editing: fixed the script indentation (spot via flake8), I
> >> removed the python2 tests as Python 2 is obsolete, and removed the space
> >> between the (procedure)[area/conditional] part of the GNU changelog
> >> commit messages.
> > thanks!
> >
> >> Another note to help with review; when sending v2 patches, make sure the
> >> title of your mail reply mentions [PATCH v2]; this helps to spot the
> >> later versions in email threads.
> > Sorry about that, will do next time.
> >
> >> The branch is shaping up nicely; I encourage you to try it.  If no major
> >> problem is found with it, I'll merge it in core-updates soon.
> > I’ve been rebuilding packages on my list that use python-build-system
> > using this branch and quite a few fail, but in a random sample I found
> > none that fails due to this patch and also I imagine some issues are
> > already fixed on core-updates? Is there anything else I can do?
>
> I guess we can be bold and merge the branch to core-updates, and fix any
> breakage that may occur there!
>
> I've done so, the last commit of the series is
> 1b9186828867e77af1f2ee6741063424f8256398.
>
> Let's make Python on Guix great again!
>
> Thank you :-)
>
> Closing,
>
> Maxim
>
>
> --- End Message ---