bug#45825: closed ([PATCH] gnu: Add efi_analyzer.)

[GNU bug Tracking System]

Your message dated Tue, 12 Jan 2021 23:02:24 +0100
with message-id <87im81olu7.fsf@nckx>
and subject line Re: [bug#45825] [PATCH] gnu: Add efi_analyzer.
has caused the debbugs.gnu.org bug report #45825,
regarding [PATCH] gnu: Add efi_analyzer.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
45825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=45825
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add efi_analyzer.
>
>
>
>
> Date: 
>
> Tue, 12 Jan 2021 20:37:47 +0100
>
>
>
>
> * gnu/packages/engineering.scm (efi_analyzer): New variable.
> ---
>  gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 5166a4635c..1c001cbe0f 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -1580,6 +1580,33 @@ like relocation symbols.  It is able to deal with 
> malformed binaries, making
>  it suitable for security research and analysis.")
>      (license license:lgpl3)))
>  
> +(define-public efi_analyzer
> +  (let ((commit "77c9e3a67cd7c2fca48a4292dad25a5429872f95")
> +        (revision "0"))
> +    (package
> +      (name "efi_analyzer")
> +      (version (git-version "0.0.0" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/xypron/efi_analyzer";)
> +                      (commit commit)))
> +                (sha256
> +                 (base32 
> "1izdkzybqyvzpzqz6kx4j7y47j6aa2dsdrychzgs65466x1a4br1"))
> +                (file-name (string-append name "-" version "-checkout"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure))
> +         #:make-flags (list "prefix=" (string-append "DESTDIR=" (assoc-ref 
> %outputs "out")))))
> +    (home-page "https://github.com/xypron/efi_analyzer";)
> +    (synopsis "Analyze EFI binary")
> +    (description
> +     "The EFI Analyzer can be used to check EFI binaries and to print out 
> header
> +and section information.")
> +    (license license:bsd-2))))
> +
>  (define-public asco
>    (package
>      (name "asco")
> -- 
> 2.30.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#45825] [PATCH] gnu: Add efi_analyzer. Date: Tue, 12 Jan 2021 23:02:24 +0100

Vincent,

Vincent Legoll 写道：

* gnu/packages/engineering.scm (efi_analyzer): New variable.

Neat!

 gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++

I failed to see any connection to engineering and moved this to efi.scm.

Don't forget to add or update your copyright line.

+      (source (origin
+                (method git-fetch)
+                (uri (git-reference

+ (url "https://github.com/xypron/efi_analyzer";)

+                      (commit commit)))
+                (sha256

+ (base32 "1izdkzybqyvzpzqz6kx4j7y47j6aa2dsdrychzgs65466x1a4br1"))

I added a newline after ‘source’ to give this 81-character line some breathing room.

URLs, snippets, ... can grow wide and a few columns can save a pointless string-append or newlines.

+ (file-name (string-append name "-" version "-checkout"))))

This can be done with the

 (file-name (git-file-name name version))

helper.

+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (delete 'configure))

Not a comment on your patch, but I added a ‘support-cross-compilation’ phase here that replaces the Makefile's hard-coded ‘gcc’ so you can inspect EFI binaries on your cross-compiled ARM box.

+ #:make-flags (list "prefix=" (string-append "DESTDIR=" (assoc-ref %outputs "out")))))

The other way 'round: set $prefix (or the BSD variant $PREFIX) to the destination, and never set DESTDIR unless you're working around a bug in a broken build system.

DESTDIR is for distributions/builds using a temporary ‘staging’ destination directory. Guix doesn't.

+    (description

+ "The EFI Analyzer can be used to check EFI binaries and to print out header

+and section information.")

Slash empty ‘x can y’ (or ‘x allows the user to y’) filler with gleeful prejudice.

Pushed with these changes as 373f808df229c12101301b766bd1810836b98481.

Thanks!

T G-R

signature.asc
Description: PGP signature

--- End Message ---