bug#44427: closed ([PATCH] lint: Add 'check-haskell-stackage' checker.)

[GNU bug Tracking System]

Your message dated Sat, 21 Nov 2020 22:21:38 -0500
with message-id <87lfeu2i0t.fsf@ngyro.com>
and subject line Re: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' 
checker.
has caused the debbugs.gnu.org bug report #44427,
regarding [PATCH] lint: Add 'check-haskell-stackage' checker.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44427: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44427
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] lint: Add 'check-haskell-stackage' checker. Date: Tue, 03 Nov 2020 21:47:23 -0500 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello!

After the most recent issue with Haskell package versions, I was
inspired to finally make it a bit better.  This patch adds a lint
checker to make sure that a Haskell package’s version is not ahead of
the desired Stackage LTS version!  The check itself is nice and simple,
but I also added a test that is anything but.

To make the test work, I made sure our Hackage and Stackage importers
use base URLs that are parameters.  Then, I used ‘with-http-server’ and
‘parameterize’d the URLs to use the local server.  (This all follows the
example of the SWH checker.)  It might be clearer if the test were split
in two, but the Stackage importer memoizes the list of packages sent
from the Stackage server.  That means that the two tests would have to
be run in a certain order to work, which is pretty dodgy.

Is the test too complicated to be worth it?  I might be able to make it
a little clearer, but I’m not sure it’s worth including at all.
Thoughts?


-- Tim

0001-lint-Add-check-haskell-stackage-checker.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker.
>
>
>
>
> Date: 
>
> Sat, 21 Nov 2020 22:21:38 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hello!
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > LGTM, thank you!
>
> Thanks for the review!
>
> > ‘%stackage-updater’ only offers versions that are in LTS Stackage,
> > right?
>
> Yup.  It tracks the version of LTS Stackage that corresponds to our
> version of GHC.
>
>
> -- Tim
>
>
> --- End Message ---