|
From: | GNU bug Tracking System |
Subject: | bug#40947: closed (Add emacs-boon) |
Date: | Mon, 16 Nov 2020 19:23:01 +0000 |
Your message dated Mon, 16 Nov 2020 20:22:38 +0100 with message-id <877dqlm7i9.fsf@nicolasgoaziou.fr> and subject line Re: [bug#40970] [PATCH] gnu: add emacs-boon has caused the debbugs.gnu.org bug report #40970, regarding Add emacs-boon to be marked as done. (If you believe you have received this mail in error, please contact help-debbugs@gnu.org.) -- 40970: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40970 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems
--- Begin Message ---Subject: Add emacs-boon Date: Tue, 28 Apr 2020 13:57:48 -0600 Hi,This patch adds the boon modal editing package0001-Add-emacs-boon-package.patch
Description: Text Data
--- End Message ---
--- Begin Message ---Subject: Re: [bug#40970] [PATCH] gnu: add emacs-boon Date: Mon, 16 Nov 2020 20:22:38 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Nicolas Goaziou <mail@nicolasgoaziou.fr> writes: > Elais Player <elais@fastmail.com> writes: > >> This patch adds the emacs-boon package with changes recommended by >> Nicolas Goaziou. > > Thank you. > >> + (description >> + "Boon is a complete package for modal editing, which is not Evil. >> +Strong points: > > Nitpick: I suggest to use a complete sentence here. > >> +@itemize >> +@item Ergonomic: common commands are easy to type. >> +@item Emacs-friendly: Emacs conventions are respected as much as compatible >> +with design goals. This means that Boon integrates well with existing Emacs >> +infrastructure, and leverages it. Existing user configuration can often be >> +re-used. >> +@item Modular: No need to buy into the whole system: mix-and-match the parts > > "No need" -> "no need" > > Also, you need to put two spaces at the end of sentences in description. > > Otherwise, LGTM. > > You generated a new patch on top of the previous one. Could you merge > both, fix the above, and send one last patch? I pushed a new iteration of this patch. I'm closing this one.
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |