--- Begin Message ---
|
Subject: |
28.0.50; vc-register, under vc-dir buffer, says file already registered |
|
Date: |
Tue, 03 Nov 2020 21:21:22 +0530 |
Steps:
1. Open vc-dir buffer `C-x v d'
2. Mark any changed file for further commands `m'
3. Goto an untracked file and press `i' (vc-register)
=> File already registered
In GNU Emacs 28.0.50 (build 2, x86_64-apple-darwin19.6.0, NS appkit-1894.60
Version 10.15.7 (Build 19H2))
of 2020-11-03 built on mb2.local
Repository revision: 2d4c981b2112083e80195c0c258422e203048946
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1894
System Description: Mac OS X 10.15.7
Configured using:
'configure LDFLAGS=-L/usr/local/opt/ruby/lib
CPPFLAGS=-I/usr/local/opt/ruby/include
PKG_CONFIG_PATH=:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/openssl/lib/pkgconfig:/usr/local/opt/libffi/lib/pkgconfig:/usr/local/opt/ruby/lib/pkgconfig'
Configured features:
JPEG TIFF GIF PNG RSVG DBUS GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2
Important settings:
value of $LC_CTYPE: UTF-8
value of $LANG: en_IN.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core term/tty-colors frame
minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind kqueue cocoa ns lcms2 multi-tty
make-network-process emacs)
Memory information:
((conses 16 52328 7020)
(symbols 48 6730 1)
(strings 32 17865 2285)
(string-bytes 1 609096)
(vectors 16 12407)
(vector-slots 8 168897 13772)
(floats 8 21 44)
(intervals 56 217 0)
(buffers 992 12))
--
Pankaj
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered |
|
Date: |
Sun, 8 Nov 2020 14:11:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Version: 28.1
On 08.11.2020 04:58, Pankaj Jangid wrote:
Dmitry Gutov <dgutov@yandex.ru> writes:
Does this work for y'all?
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 8def7da377..32664bcd25 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -1391,7 +1391,7 @@ vc-register
(unless fname
(setq fname buffer-file-name))
(when (vc-call-backend backend 'registered fname)
- (error "This file is already registered"))
+ (error "This file is already registered: %s" fname))
;; Watch out for new buffers of size 0: the corresponding file
;; does not exist yet, even though buffer-modified-p is nil.
(when bname
Yes. This is fine. User can then take action accordingly.
Very good, pushed to master.
Regarding the other concern: vc-register's docstring says:
Register into a version control system.
If VC-FILESET is given, register the files in that fileset.
Otherwise register the current file.
so the behavior seems correct.
Let us know if there's anything still amiss, though.
--- End Message ---